[PTen]Elementwise_div Kernel Refactor #37418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
YuanRisheng
changed the title
zyfncg
approved these changes
Nov 23, 2021
Comment on lines
+174
to
+175
| ASSERT_EQ(dense_out.meta().dtype, pten::DataType::FLOAT32); | ||
| ASSERT_EQ(dense_out.meta().layout, pten::DataLayout::NCHW); |
There was a problem hiding this comment.
Maybe dense_out.dtype() and dense_out.layout() is better
chenwhql
approved these changes
Nov 23, 2021
| @@ -114,6 +114,30 @@ void ElementwiseSub(const CPUContext& dev_ctx, | |||
| } | |||
| } | |||
|
|
|||
| template <typename T> | |||
| void ElementwiseDiv(const CPUContext& dev_ctx, | |||
There was a problem hiding this comment.
中间层kernel API和底层kernel API的命名是不是一致比较好，可以后续统一更改下
Shixiaowei02
approved these changes
Nov 23, 2021
Zjq9409
pushed a commit
to Zjq9409/Paddle
that referenced
this pull request
Dec 10, 2021
* elementwise_div refactor * fix compile bugs in windows ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
OPs
Describe
move elementwise_div kernel from fluid_dir to pten_dir and refactor it.