Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug fix] Fix for wrong results in segmentation models #37310

Merged
merged 5 commits into from
Nov 18, 2021

Conversation

jakpiase
Copy link
Contributor

PR types

Bug fixes

PR changes

Others

Describe

Added dcab format tag support. "Any" format tag was choosing it, but we weren't supporting that and elementwise_add kernel was causing incorrect results in a segmentation model. We really need to add memory descriptor as a field to tensor class to avoid that kind of issues in future. It is a fix for #35307

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@jakpiase jakpiase added the Intel label Nov 17, 2021
Copy link
Contributor

@jczaja jczaja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@lidanqing-intel lidanqing-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lidanqing-intel
Copy link
Contributor

@jakpiase @jczaja Could this one be merged?

@jakpiase
Copy link
Contributor Author

@lidanqing-intel yes, please merge it

@jakpiase
Copy link
Contributor Author

@jczaja please merge this PR

@jczaja jczaja merged commit c1802f9 into PaddlePaddle:develop Nov 18, 2021
@lidanqing-intel lidanqing-intel changed the title Fix for wrong results in segmentation models [Bug fix] Fix for wrong results in segmentation models Jan 27, 2022
lidanqing-intel pushed a commit to lidanqing-intel/Paddle that referenced this pull request Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants