Fix fused_attention_op scope. #37065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zkh2016
previously approved these changes
Nov 9, 2021
xingfeng01
previously approved these changes
Nov 9, 2021
limin2021
force-pushed
the
fix-fused-attention-scope
branch
from
68bc308
to
87b1bff
Compare
xingfeng01
approved these changes
Nov 10, 2021
zkh2016
approved these changes
Nov 10, 2021
lanxianghit
approved these changes
Nov 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
OPs
Describe
问题：
目前的fused_attention_op包含的范围是：
事实上，这里的layer_norm需要根据pre_layer_norm的值进行判断，只有为false的时候，此处才需要调用layer_norm。
紧随其后的pre_layer_norm为true时调用的layer_norm，放到fused_feedforward中处理。
修改：
