Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PTen] Change api->include and hapi->api #36938

Merged
merged 1 commit into from
Nov 3, 2021
Merged

[PTen] Change api->include and hapi->api #36938

merged 1 commit into from
Nov 3, 2021

Conversation

chenwhql
Copy link
Contributor

@chenwhql chenwhql commented Nov 2, 2021 •
edited
Loading

PR types

Others

PR changes

Others

Describe

[PTen] Change api->include and hapi->api

  • 由于hapi的命名可能会让用户误以为它是和Python端的hapi定位对齐的，但实际不是，pten的hapi对齐的是Python的low level API，因此商讨后，命名改为api
  • 原pten api目录表示用于内部开发者开发kernel时复用的C++ low level API，这个和Python端api没有严格对应，现在其中主要是内部头文件的一些整理，预计也只有头文件，因此改为include

@paddle-bot-old
Copy link

paddle-bot-old bot commented Nov 2, 2021

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

MingMingShangTian
MingMingShangTian approved these changes Nov 3, 2021
View reviewed changes
Copy link
Contributor

@MingMingShangTian MingMingShangTian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Avin0323
Avin0323 approved these changes Nov 3, 2021
View reviewed changes
Copy link
Contributor

@Avin0323 Avin0323 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for PR-CI-OP-benchmark

raindrops2sea
raindrops2sea approved these changes Nov 3, 2021
View reviewed changes
Copy link
Collaborator

@raindrops2sea raindrops2sea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zhiqiu
zhiqiu approved these changes Nov 3, 2021
View reviewed changes
Copy link
Contributor

@zhiqiu zhiqiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chenwhql chenwhql merged commit 3121f88 into PaddlePaddle:develop Nov 3, 2021
ghost pushed a commit to piotrekobi/Paddle that referenced this pull request Nov 3, 2021
@chenwhql @piotrekobi
change api->include and hapi->api (PaddlePaddle#36938)
b322726
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhiqiu zhiqiu zhiqiu approved these changes

@zyfncg zyfncg zyfncg approved these changes

@MingMingShangTian MingMingShangTian MingMingShangTian approved these changes

@Avin0323 Avin0323 Avin0323 approved these changes

@YuanRisheng YuanRisheng YuanRisheng approved these changes

@raindrops2sea raindrops2sea raindrops2sea approved these changes

@Shixiaowei02 Shixiaowei02 Shixiaowei02 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@chenwhql @zhiqiu @zyfncg @MingMingShangTian @Avin0323 @YuanRisheng @raindrops2sea @Shixiaowei02