Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize FasterTokenizer #36701

Merged
merged 2 commits into from
Oct 26, 2021
Merged

Optimize FasterTokenizer #36701

merged 2 commits into from
Oct 26, 2021

Conversation

joey12300
Copy link
Contributor

PR types

Performance optimization

PR changes

OPs

Describe

optimize fast tokenizer by:

  1. remove the usage of boost::split
  2. create a local BertTokenizer object in stack instead of heap.

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@ZeyuChen ZeyuChen changed the title optimize fast tokenizer Optimize FasterTokenizer Oct 25, 2021
wawltor
wawltor approved these changes Oct 26, 2021
View reviewed changes
Copy link
Contributor

@wawltor wawltor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Steffy-zxf Steffy-zxf merged commit 290ded7 into PaddlePaddle:develop Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wawltor wawltor wawltor approved these changes

@Steffy-zxf Steffy-zxf Steffy-zxf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joey12300 @wawltor @Steffy-zxf