Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix precision of momentum ops #36452

Merged
merged 1 commit into from
Oct 15, 2021
Merged

Fix precision of momentum ops #36452

merged 1 commit into from
Oct 15, 2021

Conversation

sneaxiy
Copy link
Collaborator

@sneaxiy sneaxiy commented Oct 14, 2021

PR types

Bug fixes

PR changes

OPs

Describe

I do not know why but when regularization_flag_ is a variable instead of a constant, the calculation results of momentum and merged_momentum ops differ.

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@ZzSean
Copy link
Contributor

ZzSean commented Oct 15, 2021

LGTM

JamesLim-sy
JamesLim-sy approved these changes Oct 15, 2021
View reviewed changes
Copy link
Contributor

@JamesLim-sy JamesLim-sy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sneaxiy sneaxiy merged commit 4dda18a into PaddlePaddle:develop Oct 15, 2021
@sneaxiy sneaxiy deleted the fix_momentum_op branch October 15, 2021 03:07
@sneaxiy sneaxiy mentioned this pull request Nov 10, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamesLim-sy JamesLim-sy JamesLim-sy approved these changes

@Xreki Xreki Awaiting requested review from Xreki

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sneaxiy @ZzSean @JamesLim-sy