Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

py bug fix for pslib #36102

Merged
merged 1 commit into from
Sep 28, 2021
Merged

Conversation

kuizhiqing
Copy link
Member

PR types

Bug fixes

PR changes

Others

Describe

  • py2 to py3 should use int wrap float division
  • default _iface for gloo if preferred other than "lo"
  • FLAGS_selected_gpus may not be set

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Copy link
Contributor

@danleifeng danleifeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danleifeng danleifeng merged commit 0e07f20 into PaddlePaddle:develop Sep 28, 2021
AnnaTrainingG pushed a commit to AnnaTrainingG/Paddle that referenced this pull request Sep 29, 2021
kuizhiqing added a commit to kuizhiqing/Paddle that referenced this pull request Nov 16, 2021
fuyinno4 pushed a commit that referenced this pull request Dec 1, 2021
* py2 to py3 bug and iface fix for pslib (#36102)

* avoid setting logging.basicConfig (#37031)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants