Implement Fused BN + Add + Relu with cudnnFusedOps API. #35955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
Xreki
reviewed
Sep 24, 2021
ZzSean
force-pushed
the
cudnn_bn_add_relu_test
branch
from
99b1a72
to
1aed85f
Compare
Xreki
approved these changes
Oct 9, 2021
| fwd_workspace_byte_); | ||
| } | ||
|
|
||
| void Backward(const platform::CUDADeviceContext &ctx, T *dy_ptr, T *x_ptr, |
There was a problem hiding this comment.
感觉Forward、Backward实现在不同的类里面比较好，因为这两个Forward、Backward并不是完全对应的。
| @@ -0,0 +1,292 @@ | |||
| /* Copyright (c) 2021 PaddlePaddle Authors. All Rights Reserved. | |||
There was a problem hiding this comment.
cudnn_bn_stats_finalize.cu.h和cudnn_scale_bias_add_relu.cu.h两个文件可以考虑合并成一个。
Xreki
changed the title
This was referenced Oct 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
OPs
Describe
Add bn_add_relu test
对于原始的batchnorm来说，中间所有结果的计算都是 float类型，只是在最后输出时做了一次fp32->fp16的cast；
而在融合计算中，虽然mean和std等结果都与原始相同，但是bn_finalize会输出一个fp16类型的eq_scale和eq_bias，用来进行最后的乘加，因此最终的结果会出现误差，提高单测阈值至2e-3