Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix cusparse compile bug in windows CUDA11.2, test=develop #35941

Merged
merged 2 commits into from
Sep 24, 2021
Merged

fix cusparse compile bug in windows CUDA11.2, test=develop #35941

merged 2 commits into from
Sep 24, 2021

Conversation

Liu-xiandong
Copy link
Member

PR types

Bug fixes

PR changes

Others

Describe

Currently, CUDA 11.2 of Windows does not support the SDDMM function in cusparse. It is restricted on Windows.

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@Liu-xiandong Liu-xiandong changed the title [cherry-pick] fix cusparse compile bug in windows CUDA11.2, test=develop [cherry-pick] fix cusparse compile bug in windows CUDA11.2, test=release/2.2 Sep 23, 2021
@Liu-xiandong Liu-xiandong changed the base branch from develop to release/2.2 September 23, 2021 08:11
@Liu-xiandong Liu-xiandong changed the base branch from release/2.2 to develop September 23, 2021 08:11
@Liu-xiandong Liu-xiandong changed the title [cherry-pick] fix cusparse compile bug in windows CUDA11.2, test=release/2.2 [cherry-pick] fix cusparse compile bug in windows CUDA11.2, test=develop Sep 23, 2021
@Liu-xiandong Liu-xiandong changed the title [cherry-pick] fix cusparse compile bug in windows CUDA11.2, test=develop fix cusparse compile bug in windows CUDA11.2, test=develop Sep 23, 2021
@Liu-xiandong Liu-xiandong mentioned this pull request Sep 23, 2021
Merged
@zhwesky2010
Copy link
Contributor

zhwesky2010 commented Sep 24, 2021 •
edited
Loading

https://github.com/PaddlePaddle/Paddle/blob/develop/paddle/fluid/platform/dynload/mklml.h#L51-L117 建议像这样，只禁掉SDD函数，降低对Windows影响

@Liu-xiandong
Copy link
Member Author

https://github.com/PaddlePaddle/Paddle/blob/develop/paddle/fluid/platform/dynload/mklml.h#L51-L117 建议像这样，只禁掉SDD函数，降低对Windows影响

Ok，Thanks，下个PR中修改

@zhangting2020 zhangting2020 merged commit 7c3567e into PaddlePaddle:develop Sep 24, 2021
lanxianghit pushed a commit that referenced this pull request Sep 24, 2021
@Liu-xiandong
[cherry-pick] fix cusparse compile bug in windows CUDA11.2, test=rele…
0e19aeb 
…ase/2.2 (#36015)

解决Windows中CUDA11.2编译出错的问题。
cherry-pick #35941
AnnaTrainingG pushed a commit to AnnaTrainingG/Paddle that referenced this pull request Sep 29, 2021
@Liu-xiandong @AnnaTrainingG
fix cusparse compile bug in windows CUDA11.2, test=develop (PaddlePad…
197da79 
…dle#35941)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhangting2020 zhangting2020 zhangting2020 approved these changes

@zhwesky2010 zhwesky2010 zhwesky2010 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Liu-xiandong @zhwesky2010 @zhangting2020