Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix gather_op and gather_nd_op by rectifying use of 0UL, test=develop #34138

Merged
merged 1 commit into from
Jul 14, 2021
Merged

Fix gather_op and gather_nd_op by rectifying use of 0UL, test=develop #34138

merged 1 commit into from
Jul 14, 2021

Conversation

haohongxiang
Copy link
Contributor

@haohongxiang haohongxiang commented Jul 13, 2021 •
edited
Loading

PR types

Bug fixes

PR changes

OPs

Describe

Fix gather_op and gather_nd_op by rectifying use of 0UL, replaced with 0 or 0LL.

Testing codes :
image

Before fixing : (OutOfRangeCheck doesn't work.)
image

After fixing : (OutOfRangeCheck works.)
image

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

ForFishes
ForFishes approved these changes Jul 14, 2021
View reviewed changes
Copy link
Member

@ForFishes ForFishes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ForFishes ForFishes merged commit b724703 into PaddlePaddle:develop Jul 14, 2021
@haohongxiang haohongxiang deleted the dev branch July 14, 2021 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ForFishes ForFishes ForFishes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@haohongxiang @ForFishes