[ pass_enhance ]transpose_flatten_concat_fuse_pass #33744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
Shixiaowei02
previously approved these changes
Jun 25, 2021
winter-wang
requested changes
Jun 25, 2021
There was a problem hiding this comment.
我们在 #33770 中，将transpose2的data_format属性由def移到了extra中，因此对transpose2的data_format属性不再需要兼容性检测。请在pr 33770 合入之后，移除data_format属性的兼容性检测，再合入。
winter-wang
requested changes
Jun 25, 2021
| .IsTensor() | ||
| .End() | ||
| .AddAttr("axis") | ||
| .IsIntIn({0, 1, 2, 3}) |
| .IsTensor() | ||
| .End() | ||
| .AddAttr("axis") | ||
| .IsIntIn({0, 1, 2, 3}) |
winter-wang
requested changes
Jun 28, 2021
| .AddInput("X") // Input("X"): vector<tensors> | ||
| .End() | ||
| .AddInput("AxisTensor") | ||
| .IsOptional() |
| .AddOutput("XShape") | ||
| .IsTensor() | ||
| .End() | ||
| .AddAttr("axis") |
There was a problem hiding this comment.
这个axis，我理解应该只需要大于等于0就可以，请确认一下
There was a problem hiding this comment.
在fuse的实现中必须要求是0或1，因为flatten之后为2D
Shixiaowei02
approved these changes
Jun 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
pass增强: transpose_flatten_concat_fuse_pass