Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove the tricks for paddle.fluid.layers.ops.func #33731

Merged
merged 8 commits into from
Jun 24, 2021

Conversation

wadefelix
Copy link
Contributor

PR types

Others

PR changes

Others

Describe

  1. remove the tricks for paddle.fluid.layers.ops.func Gpu samplecode test On PR-CPU-Py2 #33634
  2. refactor check_pr_approval, allow using github login-id

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

zhiqiu
zhiqiu previously approved these changes Jun 22, 2021
Copy link
Contributor

@zhiqiu zhiqiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -30,7 +30,6 @@
import pkgutil
import logging
import argparse
import paddle
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个import删除并放到下面的函数中,是为了运行test_print_signatures.py测试用例,可以在不安装paddle的环境上执行此测试用例。

Copy link
Contributor

@jzhang533 jzhang533 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
output of running python3 tools/print_signatures.py paddle may needs a clear format.

Copy link
Contributor

@zhiqiu zhiqiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lelelelelez lelelelelez merged commit ba7e2a9 into PaddlePaddle:develop Jun 24, 2021
@wadefelix wadefelix deleted the remove-trick-for-ops-func branch June 24, 2021 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants