Conv relu mkldnn fuse pass #33664
Merged
Conv relu mkldnn fuse pass #33664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
added 7 commits
June 20, 2021 12:07
… conv_relu_mkldnn_fuse_pass
winter-wang
requested changes
Jun 28, 2021
| attrs { | ||
| name: "name" | ||
| type: STRING | ||
| } | ||
| attrs { |
There was a problem hiding this comment.
这个改动我理解没有任何意义，，，没有意义的改动还是不要留着吧
| attrs { | ||
| name: "@ENABLE_CACHE_RUNTIME_CONTEXT@" | ||
| type: BOOLEAN | ||
| } |
| @@ -83,6 +88,12 @@ void ConvActivationFusePass::ApplyImpl(ir::Graph* graph) const { | |||
| desc->SetAttr("fuse_beta", | |||
| activation->Op()->GetAttrIfExists<float>("beta")); | |||
|
|
|||
| if (!IsCompat(*desc)) { | |||
| LOG(WARNING) | |||
| << "conv_activation_mkldnn_fuse_pass in out fc op compat failed."; | |||
There was a problem hiding this comment.
这个log是不是写的有问题？这儿是fc op 吗
| @@ -12,10 +12,22 @@ extra { | |||
| name: "threshold" | |||
There was a problem hiding this comment.
请确认一下 threshold是不是应该属于def?
| .End() | ||
| // float, optional, default=6.0 | ||
| .AddAttr("threshold") | ||
| .IsOptional() |
winter-wang
requested changes
Jun 29, 2021
| attrs { | ||
| name: "name" | ||
| type: STRING | ||
| } | ||
| attrs { |
There was a problem hiding this comment.
这个改动我理解没有任何意义，，，没有意义的改动还是不要留着吧
added 6 commits
June 29, 2021 08:02
winter-wang
requested changes
Jun 30, 2021
| @@ -83,6 +88,12 @@ void ConvActivationFusePass::ApplyImpl(ir::Graph* graph) const { | |||
| desc->SetAttr("fuse_beta", | |||
| activation->Op()->GetAttrIfExists<float>("beta")); | |||
|
|
|||
| if (!IsCompat(*desc)) { | |||
There was a problem hiding this comment.
这一部分删了吧，不用检测。如果这儿检测失败提前返回的话，graph属于改了一部分的状态，就完蛋了
Shixiaowei02
approved these changes
Jul 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
enhance conv_relu_mkldnn_pass