Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add op_compat for the seqpool_cvm_concat_fuse_pass, test=develop #33559

Merged
merged 5 commits into from
Jun 23, 2021

Conversation

Shixiaowei02
Copy link
Contributor

PR types

Others

PR changes

Others

Describe

add op_compat for the seqpool_cvm_concat_fuse_pass, test=develop

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

.AddOutput("MaxIndex")
.End()
.AddAttr("pooltype")
.End()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pooltype需要约束条件

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

.AddOutput("Out")
.IsTensor()
.End()
.AddOutput("MaxIndex")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MaxIndex需要约束条件 IsTensor().IsOptional() ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

DannyIsFunny
DannyIsFunny previously approved these changes Jun 22, 2021
Copy link
Contributor

@DannyIsFunny DannyIsFunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wadefelix
Copy link
Contributor

https://xly.bce.baidu.com/paddlepaddle/paddle/newipipe/detail/3024191/job/5177790
这个PR-CI-CPU-Py2 是受 ops.func 影响了,可以忽略此错误

Copy link
Contributor

@winter-wang winter-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Shixiaowei02
Copy link
Contributor Author

https://xly.bce.baidu.com/paddlepaddle/paddle/newipipe/detail/3024191/job/5177790
这个PR-CI-CPU-Py2 是受 ops.func 影响了,可以忽略此错误

收到,谢谢

Copy link
Contributor

@DannyIsFunny DannyIsFunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Shixiaowei02 Shixiaowei02 merged commit 5f198a6 into PaddlePaddle:develop Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants