support Ninja, establish dependencies relationship between paddle with third_party #33140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
zhwesky2010
force-pushed
the
support_ninja
branch
from
fc79d4f
to
8071b85
Compare
zhwesky2010
force-pushed
the
support_ninja
branch
from
8071b85
to
a5c1097
Compare
zhwesky2010
force-pushed
the
support_ninja
branch
from
a5c1097
to
4071794
Compare
zhwesky2010
force-pushed
the
support_ninja
branch
from
4071794
to
19bc822
Compare
zhwesky2010
changed the title
zhwesky2010
force-pushed
the
support_ninja
branch
from
19bc822
to
470add1
Compare
|
Sorry to inform you that 470add1's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually. |
|
Sorry to inform you that a1b0645's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually. |
zhwesky2010
force-pushed
the
support_ninja
branch
from
f7eb625
to
de56a33
Compare
zhwesky2010
force-pushed
the
support_ninja
branch
from
de56a33
to
3a6cc01
Compare
zhwesky2010
changed the title
zhwesky2010
changed the title
wanghuancoder
approved these changes
Jun 28, 2021
wanghuancoder
approved these changes
Jun 28, 2021
This was referenced Feb 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
Others
Describe
在Windows，Ninja具有更好的编译速度与稳定性，因此Paddle支持Ninja编译；
在Paddle编译依赖关系中，如果在cmake中指定
Target A依赖文件B，而文件B依赖Target C，对于make或MSVC构建系统中，无需明确描述文件B的来源，会缺省建立Target A与Target C的依赖关系。但是在Ninja构建系统中，其要求严格明确的构建规则，必须要指明
文件B的来源，否则会报错：在Paddle中第三方库中大量使用了如上语法形式，因此需通过
ExternalProjectAdd语法BUILD_BYPRODUCTS对产出文件进行了绑定，以建立正确的Ninja编译规则，Windows CI同时会开启Ninja编译检查。