Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【Deepmd Support】add IsInitialized and tanh double grad #32188

Merged
merged 4 commits into from
Apr 15, 2021

Conversation

JiabinYang
Copy link
Contributor

@JiabinYang JiabinYang commented Apr 11, 2021

PR types

New features

PR changes

OPs

Describe

This PR add IsInitialized API into paddle::Tensor to support user check whether their input tensor is ready to support deepmd custom op in PR https://github.com/deepmodeling/deepmd-kit/pull/499
And Add tanhDoubleGrad kernel to support SEA net work of deepmd
https://github.com/deepmodeling/deepmd-kit/blob/api/examples/water/train/water_se_a.json

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@JiabinYang JiabinYang changed the title 【Custom op】add IsInitialized 【Deepmd Support】add IsInitialized and tanh double grad Apr 13, 2021
@@ -113,6 +113,9 @@ class PD_DLL_DECL Tensor {
/// \brief Cast datatype from one to another
Tensor cast(const DataType& target_type) const;

/// \brief Check Tensor is initialized
bool IsInitialized() const;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API名其他都是小写,都统一成小写?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure

Copy link
Contributor

@ceci3 ceci3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tanh double grad LGTM

Copy link
Contributor

@chenwhql chenwhql left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JiabinYang JiabinYang merged commit cfdde0e into PaddlePaddle:develop Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants