update cmake minimum version to 3.15 #31807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
zhwesky2010
reviewed
Mar 31, 2021
| @@ -12,7 +12,8 @@ | |||
| # See the License for the specific language governing permissions and | |||
| # limitations under the License | |||
|
|
|||
| cmake_minimum_required(VERSION 3.10) | |||
| cmake_minimum_required(VERSION 3.15) | |||
| cmake_policy(VERSION 3.10) | |||
There was a problem hiding this comment.
cmake_policy会影响哪些方面，默认是cmake_policy(VERSION 3.15)就会触发上次那个问题吗
There was a problem hiding this comment.
cmake_minimum_required会内部调用cmake_policy，会影响cmake一些行为，比如Windows下RuntimeLibrary在3.10从CXX_FLAGS中获取，在高版本中改为从CMAKE_MSVC_RUNTIME_LIBRARY获取。
这个限制最低版本到3.15，为了保证整体cmake配置与以前一致，显示调用cmake_policy来保持兼容性。
zhwesky2010
approved these changes
Mar 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
Update CMake minimum version to avoid CMake Error like #31748 .