Added LSTM BF16 and fixed GRU BF16 #31234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
|
✅ This PR's description meets the template requirements! |
|
@luotao1 Could you please start your review? |
lelelelelez
reviewed
Jun 7, 2021
|
|
||
| if self.with_bias: | ||
| self.inputs['Bias'] = bias | ||
|
|
||
| if self.with_h0: | ||
| self.inputs['H0'] = h0_bf16 | ||
| if self.weights_dtype == 'bf16': | ||
| self.inputs['H0'] = h0_bf16 |
There was a problem hiding this comment.
hi @jakpiase , you use variable h0_bf16 before assignment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
New features
PR changes
OPs
Describe
Added support for LSTM bf16. Added support for bf16 and fp32 weights and h0 memory datatypes. In future int8 will be supported as weights datatype too.