Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[oneDNN] Initial bf16 amp integration #31093

Merged
merged 33 commits into from
Mar 22, 2021

Conversation

arlesniak
Copy link
Contributor

@arlesniak arlesniak commented Feb 22, 2021

PR types

New features

PR changes

APIs

Describe

Initial bf16 amp integration

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@jczaja jczaja added the Intel label Feb 22, 2021
@jczaja jczaja self-requested a review February 22, 2021 10:27
@arlesniak arlesniak changed the title Initial bf16 amp integration [oneDNN] Initial bf16 amp integration Feb 23, 2021
paddle-bot-old bot referenced this pull request Mar 1, 2021
paddle-bot-old bot referenced this pull request Mar 1, 2021
paddle-bot-old bot referenced this pull request Mar 1, 2021
paddle-bot-old bot referenced this pull request Mar 3, 2021
@arlesniak
Copy link
Contributor Author

I restarted PR-CI-musl a couple of times but every time it has the following error:
fatal: unable to access 'https://github.com/PaddlePaddle/Paddle.git/': Failed connect to 172.19.57.45:3128; Connection timed out

@luotao1
Copy link
Contributor

luotao1 commented Mar 19, 2021

I restart PR_CI_MUSL and it runs OK now.

Copy link
Contributor

@arogowie-intel arogowie-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry I couldn't review your code thoroughly since it's too hard and time consuming for me without having more knowledge about actual implementation for this topic. Thus some of my comments may be inaccurate.

@arlesniak
Copy link
Contributor Author

@arogowie-intel Thank you for the comments

@arlesniak arlesniak requested a review from jczaja March 19, 2021 16:14
@arlesniak
Copy link
Contributor Author

@arogowie-intel Thank you for your comments.

@arlesniak arlesniak requested a review from luotao1 March 20, 2021 11:24
Copy link
Contributor

@luotao1 luotao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1
Copy link
Contributor

luotao1 commented Mar 22, 2021

2021-03-20 00:31:12 ****************

2021-03-20 00:31:12 0. You must have one RD (XiaoguangHu01 or lanxianghit) and one TPM (saxon-zh or jzhang533 or swtkiwi or Heeenrrry or TCChenlong) approval for the api change for the management reason of API interface.

2021-03-20 00:31:12 1. You must have one TPM (saxon-zh or jzhang533 or swtkiwi or Heeenrrry or TCChenlong) approval for the api change for the management reason of API document.

2021-03-20 00:31:12 

2021-03-20 00:31:12 There are 2 approved errors.

2021-03-20 00:31:12 ****************

2021-03-20 00:31:12 API Difference is: 

2021-03-20 00:31:12 + paddle.fluid.contrib.mixed_precision.AutoMixedPrecisionListsBF16 (paddle.fluid.contrib.mixed_precision.bf16.amp_lists.AutoMixedPrecisionListsBF16, ('document', '1aea006c5da7d91bb0e8b7c6dba32c01'))

2021-03-20 00:31:12 + paddle.fluid.contrib.mixed_precision.AutoMixedPrecisionListsBF16.__init__ (ArgSpec(args=['self', 'custom_bf16_list', 'custom_fp32_list', 'custom_fp32_varnames'], varargs=None, keywords=None, defaults=(None, None, None)), ('document', '6adf97f83acf6453d4a6a4b1070f3754'))

2021-03-20 00:31:12 + paddle.fluid.contrib.mixed_precision.bf16_guard (ArgSpec(args=[], varargs=None, keywords=None, defaults=None), ('document', 'd2a4daf8c41dabdf686dba448a4d23ff'))

2021-03-20 00:31:12 + paddle.fluid.contrib.mixed_precision.rewrite_program_bf16 (ArgSpec(args=['main_prog', 'amp_lists', 'use_bf16_guard'], varargs=None, keywords=None, defaults=(None, False)), ('document', '9849657dba7a5c8a2e2b98894183276d'))

2021-03-20 00:31:12 + paddle.fluid.contrib.mixed_precision.convert_float_to_uint16 (ArgSpec(args=['in_list'], varargs=None, keywords=None, defaults=None), ('document', '6adf97f83acf6453d4a6a4b1070f3754'))

Copy link
Contributor

@swtkiwi swtkiwi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1 luotao1 merged commit 7ccf6b6 into PaddlePaddle:develop Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants