Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[oneDNN] Added basic changes for elementwise_add_grad bf16 #30925

Merged

Conversation

jczaja
Copy link
Contributor

@jczaja jczaja commented Feb 5, 2021

PR types

Performance optimization

PR changes

OPs

Describe

It does introuce elementwise_add grad bf16 oneDNN kernel

@paddle-bot-old
Copy link

paddle-bot-old bot commented Feb 5, 2021

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@jczaja jczaja requested a review from wozna February 5, 2021 11:21
@jczaja
Copy link
Contributor Author

jczaja commented Feb 5, 2021

@arlesniak , @arogowie-intel Please take a look

@jczaja jczaja added the Intel label Feb 5, 2021
lint

- fix to UT

- removed uneeded error margin redefining
@jczaja jczaja force-pushed the prv-elementwise_add-grad-bf16-pr branch from 69b4008 to 3619ae2 Compare February 5, 2021 11:31
Copy link
Contributor

@wozna wozna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jczaja
Copy link
Contributor Author

jczaja commented Feb 5, 2021

@luotao1 Could you please start your review? PR-CI-APPROVAL needs approval to pass

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants