Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add avx512 core instructions check #27732

Merged
merged 4 commits into from
Sep 30, 2020
Merged

Conversation

wozna
Copy link
Contributor

@wozna wozna commented Sep 29, 2020

PR types

Bug fixes

PR changes

OPs

Describe

This PR adds avx512 core instruction check in bfloat16 convolution test. Bfloat16 evaluation is possible only if the CPU has AVX512BW, AVX512VL, and AVX512DQ flags. Without them, all tests with bfloat16 will fail.
It is related to #27588

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

paddle/fluid/pybind/pybind.cc Outdated Show resolved Hide resolved
paddle/fluid/pybind/pybind.cc Outdated Show resolved Hide resolved
Copy link

@wojtuss wojtuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@jczaja jczaja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@wojtuss wojtuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jczaja
Copy link
Contributor

jczaja commented Sep 30, 2020

@luotao1 Could you please start your review?

@luotao1 luotao1 merged commit 0cd4907 into PaddlePaddle:develop Sep 30, 2020
@wozna wozna deleted the bfloat16_check branch February 24, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants