Improve brpccmake #11842
Merged
Improve brpccmake #11842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typhoonzero
reviewed
Jun 29, 2018
cmake/external/openssl.cmake
Outdated
| INSTALL_DIR ${OPENSSL_INSTALL_DIR} | ||
| CONFIGURE_COMMAND ./config -fPIC no-shared --prefix=${OPENSSL_INSTALL_DIR} | ||
| BUILD_IN_SOURCE 1 | ||
| BUILD_COMMAND $(MAKE) -j 12 |
There was a problem hiding this comment.
Can use make -j to use all the cores.
cmake/external/openssl.cmake
Outdated
| # limitations under the License. | ||
| # | ||
|
|
||
| IF(MOBILE_INFERENCE OR NOT WITH_DISTRIBUTE) |
There was a problem hiding this comment.
Can we use the openssl package in the OS like yum install openssl-devel?
There was a problem hiding this comment.
typhoonzero
approved these changes
Jun 30, 2018
|
|
||
| # If minimal .a is need, you can set WITH_DEBUG_SYMBOLS=OFF | ||
| ExternalProject_Add( | ||
| extern_brpc | ||
| ${EXTERNAL_PROJECT_LOG_ARGS} | ||
| GIT_REPOSITORY "https://github.com/brpc/brpc" | ||
| GIT_TAG "6d153dd7ff00f960ae6895c9c5fff0ce9f07aff2" | ||
| GIT_REPOSITORY "https://github.com/gongweibao/brpc" |
There was a problem hiding this comment.
Add TODO here that we should change to brpc repo once they are updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.