Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add argmin and argmax op #11313

Merged
merged 3 commits into from
Jun 11, 2018
Merged

Add argmin and argmax op #11313

merged 3 commits into from
Jun 11, 2018

Conversation

sneaxiy
Copy link
Collaborator

@sneaxiy sneaxiy commented Jun 8, 2018

No description provided.

@CLAassistant
Copy link

CLAassistant commented Jun 8, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@sneaxiy sneaxiy force-pushed the argmin_argmax branch 4 times, most recently from b84a02b to 568c4e5 Compare June 8, 2018 11:38
sneaxiy and others added 2 commits June 8, 2018 11:42
@sneaxiy
remove redundant comments
6d32e96
@reyoung
Polish arg_min_max_op
9b43ede 
* Remove unused arg_max/min_op.h
* Remove reference parameter. Use pointer insteaded.
* undef macro
* Always set OutT as int64_t.
reyoung
reyoung approved these changes Jun 11, 2018
View reviewed changes
Copy link
Collaborator

@reyoung reyoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent

@sneaxiy sneaxiy merged commit 831909c into PaddlePaddle:develop Jun 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reyoung reyoung reyoung approved these changes

@wangkuiyi wangkuiyi Awaiting requested review from wangkuiyi

@JiayiFeng JiayiFeng Awaiting requested review from JiayiFeng

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sneaxiy @CLAassistant @reyoung