【Hackathon 9th No.22】add unit tests for share_external_data #3744
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
Collaborator
|
请讲22和56题分开两个PR |
ooooo-create
force-pushed
the
test/add_unit_tests_for_share_external_data
branch
from
a21986c to
2d8b07a
Compare
ooooo-create
changed the title
Collaborator
|
验证方法是ok的，但是逻辑稍微有点复杂了，直接连续调用set_data_ipc和share_external_data验证结果有什么问题吗 |
ming1753
approved these changes
Sep 8, 2025
Collaborator
@ooooo-create 后续可以优化下？ |
Contributor
Author
抱歉这么晚回复，直接调用应该是可以的，我本来想本地测试一下再回复的，后来一直没有时间本地测试，忘记回复了。当时这么做是因为这个 api 应该是用来跨进程通信的，为了模拟这个场景，我就是一个进程set_data_ipc，另一个进程进行 share_external_data ，如果不需要这样子做，我后面有时间改一下～ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
share_external_data