Skip to content

Fix Open Graph / Twitter image metadata for landing & guides and add tests #2428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andrew-bierman merged 4 commits into from
May 17, 2026
Merged

Fix Open Graph / Twitter image metadata for landing & guides and add tests #2428

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1a4ec3f
Fix OG/Twitter image metadata and add coverage
andrew-bierman May 16, 2026
d1e2f82
Use Next metadata image routes for OG/Twitter URLs
andrew-bierman May 16, 2026
6b0206c
Merge origin/development
andrew-bierman May 16, 2026
c627e35
Move metadata tests to __tests__ dir so vitest picks them up
andrew-bierman May 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions apps/guides/__tests__/layout.metadata.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
import { describe, expect, it } from 'vitest';
import { siteConfig } from '../lib/config';
import { guidesMetadata as metadata } from '../lib/metadata';

describe('guides metadata', () => {
it('includes absolute Open Graph and Twitter image URLs', () => {
Comment on lines +5 to +6
const expectedImageUrl = new URL('/opengraph-image.png', siteConfig.url).toString();

expect(metadata.openGraph?.images).toEqual([
{
url: expectedImageUrl,
width: 1200,
height: 630,
alt: 'PackRat Guides | Hiking & Outdoor Adventures',
},
]);

expect(metadata.twitter?.images).toEqual([
new URL('/twitter-image.png', siteConfig.url).toString(),
]);
});
});
11 changes: 9 additions & 2 deletions apps/guides/lib/metadata.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,14 +27,21 @@ export const guidesMetadata: Metadata = {
siteName: 'PackRat Guides',
title: 'PackRat Guides | Hiking & Outdoor Adventures',
description: 'Expert hiking and outdoor guides to help you prepare for your next adventure',
images: [{ url: '/og-image.png', width: 1200, height: 630, alt: 'PackRat Guides' }],
images: [
{
url: new URL('/opengraph-image.png', siteConfig.url).toString(),
width: 1200,
height: 630,
alt: 'PackRat Guides | Hiking & Outdoor Adventures',
},
],
},
twitter: {
card: 'summary_large_image',
title: 'PackRat Guides | Hiking & Outdoor Adventures',
description: 'Expert hiking and outdoor guides to help you prepare for your next adventure',
creator: '@packratai',
images: ['/og-image.png'],
images: [new URL('/twitter-image.png', siteConfig.url).toString()],
},
icons: {
icon: [{ url: '/PackRatGuides.ico', type: 'image/x-icon' }],
Expand Down
22 changes: 22 additions & 0 deletions apps/landing/__tests__/layout.metadata.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
import { describe, expect, it } from 'vitest';
import { siteConfig } from '../config/site';
import { landingMetadata as metadata } from '../lib/metadata';

describe('landing metadata', () => {
it('includes absolute Open Graph and Twitter image URLs', () => {
Comment on lines +5 to +6
const expectedImageUrl = new URL('/opengraph-image.png', siteConfig.url).toString();

expect(metadata.openGraph?.images).toEqual([
{
url: expectedImageUrl,
width: 1200,
height: 630,
alt: siteConfig.name,
},
]);

expect(metadata.twitter?.images).toEqual([
new URL('/twitter-image.png', siteConfig.url).toString(),
]);
});
});
11 changes: 9 additions & 2 deletions apps/landing/lib/metadata.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,14 +18,21 @@ export const landingMetadata: Metadata = {
title: siteConfig.name,
description: siteConfig.description,
siteName: siteConfig.name,
images: [{ url: '/og-image.png', width: 1200, height: 630, alt: siteConfig.name }],
images: [
{
url: new URL('/opengraph-image.png', siteConfig.url).toString(),
width: 1200,
height: 630,
alt: siteConfig.name,
},
],
},
twitter: {
card: 'summary_large_image',
title: siteConfig.name,
description: siteConfig.description,
creator: siteConfig.twitterHandle,
images: ['/og-image.png'],
images: [new URL('/twitter-image.png', siteConfig.url).toString()],
},
icons: {
icon: '/PackRat.ico',
Expand Down
Loading