fix: improve Lighthouse LCP scores for guides and landing apps#2304
Merged
Conversation
Agent-Logs-Url: https://github.com/PackRat-AI/PackRat/sessions/396e79f1-4bef-4512-802b-b8f182cd9250 Co-authored-by: andrew-bierman <94939237+andrew-bierman@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
andrew-bierman
April 26, 2026 01:02
View session
Contributor
Deploying packrat-landing with
|
| Latest commit: |
40095d4
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://b10a00d3.packrat-landing.pages.dev |
| Branch Preview URL: | https://copilot-improve-lighthouse-s.packrat-landing.pages.dev |
Contributor
Deploying packrat-guides with
|
| Latest commit: |
40095d4
|
| Status: | 🚫 Build failed. |
…unnecessary 'use client' directives Agent-Logs-Url: https://github.com/PackRat-AI/PackRat/sessions/4c56e6bb-bbc6-4033-9d86-d72ec9deb619 Co-authored-by: andrew-bierman <94939237+andrew-bierman@users.noreply.github.com>
github-actions
Bot
added
the
dependencies
Contributor
Coverage Report for Expo Unit Tests Coverage (./apps/expo)
File CoverageNo changed files found. |
Contributor
Coverage Report for API Unit Tests Coverage (./packages/api)
File Coverage
|
||||||||||||||||||||||||||||||||||||||
Agent-Logs-Url: https://github.com/PackRat-AI/PackRat/sessions/18022a11-7288-4e72-adc3-9e2add9ac4f6 Co-authored-by: andrew-bierman <94939237+andrew-bierman@users.noreply.github.com>
Contributor
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
packrat-admin | 40095d4 | Commit Preview URL Branch Preview URL |
May 16 2026, 10:33 PM |
…truction Agent-Logs-Url: https://github.com/PackRat-AI/PackRat/sessions/e15d3f21-af97-454a-8147-e275ad61898f Co-authored-by: andrew-bierman <94939237+andrew-bierman@users.noreply.github.com>
Collaborator
|
@copilot fix failing ci and resolve merge conflicts |
…house-scores # Conflicts: # apps/admin/components/auth-guard.tsx # apps/admin/lib/cfAccess.ts # apps/expo/features/trips/screens/TripWeatherDetailsScreen.tsx # bun.lock # packages/api/src/routes/admin/index.ts
Contributor
Author
Done. Merged
|
…house-scores Co-authored-by: andrew-bierman <94939237+andrew-bierman@users.noreply.github.com>
Resolve conflicts:
- apps/guides/app/page.tsx — dev independently server-rendered the hero +
features + featured-guides sections and split filter UI into a small client
component (FilterableGuides). That's stricter LCP optimization than this
PR's monolithic GuidesContent client component, so keep dev's version
(also drops the redundant components/guides-content.tsx).
- apps/guides/components/header.tsx — keep dev's useMemo() wrapping of
getAllCategories() (prevents re-walking posts on scroll re-renders).
- apps/landing/package.json — keep dev's catalog: references (project
convention) plus dev's @emotion/is-prop-valid + framer-motion additions.
Verification:
- bun check-types: passes
- bun check: Biome clean
- apps/{guides,landing}/app/page.tsx are server components (no 'use client')
- useSearchParams remains in components/filterable-guides.tsx
Collaborator
|
Rebased onto current Conflicts resolved:
Verification (locally, in worktree):
Push: |
github-actions
Bot
added
documentation
8 tasks
Matches packageManager (bun@1.3.10) but locks the actual version used in CI / CF Pages to 1.3.14 to mirror what's already running in worktrees and mcp-cli-eden. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
github-actions
Bot
removed
documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
apps/expo/features/packs/store/packWeightHistory.ts— replaceas any+ biome-ignore by constructing explicit body{ id, weight, localCreatedAt }matching the API's Zod schemaapps/admin/lib/cfAccess.ts— Zod schema +safeParse(taken from main);useCFAccessIdentityhook addedpackages/api/src/middleware/cfAccess.ts— updated to positional args(request, teamDomain, aud)matching callersapps/expo/features/trips/screens/TripWeatherDetailsScreen.tsx— TS error fixed: optional chaining onforecastday[0]?.dayorigin/main(iOS inset adjustments) — clean, no conflicts