fix(expo): #2256 broken search UI layout#2262
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR fixes the broken iOS search results layout (issue #2256) by standardizing how LargeTitleHeader search content is wrapped and rendered across affected screens, ensuring proper safe-area handling and an opaque background behind search results.
Changes:
- Introduces a reusable
LargeTitleHeaderSearchContentContainerto applyflex: 1and themed background (and SafeAreaView on iOS). - Wraps
LargeTitleHeadersearchcontentin Trips, Packs, Catalog, and Dashboard screens with the new container. - Updates Packs
SearchResultsto render as a full-height list (removing the previous card-like wrapper) and adds list padding viacontentContainerClassName.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| apps/expo/features/trips/screens/TripListScreen.tsx | Wraps search content in the new container for consistent iOS layout/background behavior. |
| apps/expo/features/packs/screens/PackListScreen.tsx | Wraps search content in the new container so search results render with correct background/safe area. |
| apps/expo/features/packs/components/SearchResults.tsx | Adjusts search results rendering to a plain FlatList with padding, relying on the new container for background/layout. |
| apps/expo/features/catalog/screens/CatalogItemsScreen.tsx | Replaces inline background wrapper with the new container for search content. |
| apps/expo/components/LargeTitleHeaderSearchContentContainer.tsx | Adds the shared container component applying safe-area (iOS) and background color. |
| apps/expo/app/(app)/(tabs)/(home)/index.tsx | Wraps dashboard search content in the new container and tweaks FlatList container spacing. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…yout fix(expo): #2256 broken search UI layout
resolves #2256