Skip to content

fix(expo): #2256 broken search UI layout#2262

Merged
mikib0 merged 1 commit into
developmentfrom
fix/2256-broken-search-ui-layout
Apr 20, 2026
Merged

fix(expo): #2256 broken search UI layout#2262
mikib0 merged 1 commit into
developmentfrom
fix/2256-broken-search-ui-layout

Conversation

@mikib0
Copy link
Copy Markdown
Collaborator

@mikib0 mikib0 commented Apr 20, 2026

resolves #2256

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 20, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 22b8660e-d969-4a3b-90fd-e43ab5446813

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/2256-broken-search-ui-layout

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes the broken iOS search results layout (issue #2256) by standardizing how LargeTitleHeader search content is wrapped and rendered across affected screens, ensuring proper safe-area handling and an opaque background behind search results.

Changes:

  • Introduces a reusable LargeTitleHeaderSearchContentContainer to apply flex: 1 and themed background (and SafeAreaView on iOS).
  • Wraps LargeTitleHeader search content in Trips, Packs, Catalog, and Dashboard screens with the new container.
  • Updates Packs SearchResults to render as a full-height list (removing the previous card-like wrapper) and adds list padding via contentContainerClassName.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
apps/expo/features/trips/screens/TripListScreen.tsx Wraps search content in the new container for consistent iOS layout/background behavior.
apps/expo/features/packs/screens/PackListScreen.tsx Wraps search content in the new container so search results render with correct background/safe area.
apps/expo/features/packs/components/SearchResults.tsx Adjusts search results rendering to a plain FlatList with padding, relying on the new container for background/layout.
apps/expo/features/catalog/screens/CatalogItemsScreen.tsx Replaces inline background wrapper with the new container for search content.
apps/expo/components/LargeTitleHeaderSearchContentContainer.tsx Adds the shared container component applying safe-area (iOS) and background color.
apps/expo/app/(app)/(tabs)/(home)/index.tsx Wraps dashboard search content in the new container and tweaks FlatList container spacing.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mikib0 mikib0 merged commit c87bc8f into development Apr 20, 2026
7 of 10 checks passed
@mikib0 mikib0 deleted the fix/2256-broken-search-ui-layout branch April 20, 2026 14:46
andrew-bierman pushed a commit that referenced this pull request May 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants