Skip to content

claude/setup-admin-app-structure-eOiWV#2189

Merged
andrew-bierman merged 5 commits into
developmentfrom
claude/setup-admin-app-structure-eOiWV
Apr 16, 2026
Merged

claude/setup-admin-app-structure-eOiWV#2189
andrew-bierman merged 5 commits into
developmentfrom
claude/setup-admin-app-structure-eOiWV

Conversation

@andrew-bierman
Copy link
Copy Markdown
Collaborator

Add missing scaffolding to bring the admin app to parity with the
landing and guides apps:

  • vercel.json — security response headers (X-Frame-Options, nosniff, etc.)
  • pages/404.tsx + pages/500.tsx — static custom error pages (works with output: export)
  • app/not-found.tsx — App Router 404 handler with Tailwind/themed styles

https://claude.ai/code/session_01LqN8nDxX8KMs8s53J4DGVD

claude added 4 commits April 16, 2026 03:23
Add missing scaffolding to bring the admin app to parity with the
landing and guides apps:

- vercel.json — security response headers (X-Frame-Options, nosniff, etc.)
- pages/404.tsx + pages/500.tsx — static custom error pages (works with output: export)
- app/not-found.tsx — App Router 404 handler with Tailwind/themed styles

https://claude.ai/code/session_01LqN8nDxX8KMs8s53J4DGVD
Drop vercel.json from landing and admin (not deployed to Vercel) and
strip .vercel from the clean scripts in landing and guides.

https://claude.ai/code/session_01LqN8nDxX8KMs8s53J4DGVD
- wrangler.jsonc: configures packrat-admin as a Workers static assets
  project, serving from ./out with 404-page handling
- public/_headers: security response headers for admin, landing, and
  guides (replaces the now-deleted vercel.json files)

https://claude.ai/code/session_01LqN8nDxX8KMs8s53J4DGVD
Same wrangler.jsonc pattern as admin — serves ./out with 404-page
handling. _headers already in place from the previous commit.

https://claude.ai/code/session_01LqN8nDxX8KMs8s53J4DGVD
@cloudflare-workers-and-pages
Copy link
Copy Markdown
Contributor

Deploying packrat-guides with  Cloudflare Pages  Cloudflare Pages

Latest commit: b3ba7fa
Status: ✅  Deploy successful!
Preview URL: https://cc7bbb45.packrat-guides-6gq.pages.dev
Branch Preview URL: https://claude-setup-admin-app-struc.packrat-guides-6gq.pages.dev

View logs

@cloudflare-workers-and-pages
Copy link
Copy Markdown
Contributor

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
❌ Deployment failed
View logs
packrat-admin b3ba7fa Apr 16 2026, 03:43 AM

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 16, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 0e45337f-84f8-4e3f-a6c6-792fcb6dbd40

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/setup-admin-app-structure-eOiWV

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added dependencies Pull requests that update a dependency file web labels Apr 16, 2026
@andrew-bierman andrew-bierman marked this pull request as ready for review April 16, 2026 03:51
Copilot AI review requested due to automatic review settings April 16, 2026 03:51
@andrew-bierman andrew-bierman merged commit 92812d0 into development Apr 16, 2026
8 of 9 checks passed
@andrew-bierman andrew-bierman deleted the claude/setup-admin-app-structure-eOiWV branch April 16, 2026 03:51
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds Cloudflare-oriented deployment scaffolding and static error handling so the admin app (and related static apps) work cleanly with next.config output: 'export' and security headers.

Changes:

  • Add wrangler.jsonc configs for landing, guides, and admin to serve ./out with 404-page handling.
  • Replace Vercel header configuration with Cloudflare Pages-style public/_headers across apps.
  • Add admin 404/500 pages plus an App Router app/not-found.tsx; update clean scripts to stop deleting .vercel.

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
apps/landing/wrangler.jsonc Cloudflare Wrangler config pointing static assets to ./out.
apps/landing/vercel.json Removed Vercel-specific response header configuration.
apps/landing/public/_headers Adds security headers via Cloudflare Pages _headers.
apps/landing/package.json Updates clean script to stop deleting .vercel.
apps/guides/wrangler.jsonc Cloudflare Wrangler config for exported output.
apps/guides/public/_headers Adds security headers via _headers.
apps/guides/package.json Updates clean script to stop deleting .vercel.
apps/admin/wrangler.jsonc Cloudflare Wrangler config for exported output.
apps/admin/public/_headers Adds security headers via _headers.
apps/admin/pages/404.tsx Adds a static custom 404 page (Pages Router).
apps/admin/pages/500.tsx Adds a static custom 500 page (Pages Router).
apps/admin/app/not-found.tsx Adds an App Router 404 handler with themed/Tailwind styles.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread apps/admin/pages/404.tsx
Comment on lines +1 to +5
import { Backpack } from 'lucide-react';

export default function Custom404() {
return (
<div
Copy link

Copilot AI Apr 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The admin 404 is now implemented in two places (pages/404.tsx and app/not-found.tsx) with different styling/markup. With output: 'export' and Cloudflare not_found_handling: "404-page", only one of these will become the deployed 404.html, so this duplication can lead to inconsistent UX and future drift. Consider consolidating to a single source of truth (e.g., share a common component, or keep only the one that is actually used for the exported 404).

Copilot uses AI. Check for mistakes.
Comment thread apps/admin/pages/500.tsx
Comment on lines +1 to +6
import { AlertTriangle } from 'lucide-react';

export default function Custom500() {
return (
<div
style={{
Copy link

Copilot AI Apr 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pages/500.tsx provides a /500 route for the Pages Router, but the admin app is primarily using the App Router (apps/admin/app/*). Runtime render errors in App Router routes won’t use this page; they require app/error.tsx (and optionally app/global-error.tsx) to show a custom 500-style experience. Consider adding an App Router error boundary so production errors don’t fall back to Next’s default error UI.

Copilot uses AI. Check for mistakes.
Comment on lines +1 to +5
/*
X-Frame-Options: DENY
X-Content-Type-Options: nosniff
Referrer-Policy: strict-origin-when-cross-origin
Permissions-Policy: camera=(), microphone=(), geolocation=()
Copy link

Copilot AI Apr 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR description mentions adding vercel.json security headers, but this change removes apps/landing/vercel.json and replaces the behavior with Cloudflare Pages-style public/_headers. Please update the PR description (and/or deployment docs) to reflect the actual approach so reviewers/operators don’t assume Vercel headers are still in effect.

Copilot uses AI. Check for mistakes.
andrew-bierman added a commit that referenced this pull request May 14, 2026
…ture-eOiWV

claude/setup-admin-app-structure-eOiWV
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file web

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants