chore(deps): fix version mismatches and consolidate into bun catalog#2070
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Coverage Report for API Unit Tests Coverage (./packages/api)
File CoverageNo changed files found. |
Coverage Report for Expo Unit Tests Coverage (./apps/expo)
File CoverageNo changed files found. |
Deploying packrat-guides with
|
| Latest commit: |
b039ff3
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://cef5cf65.packrat-guides-6gq.pages.dev |
| Branch Preview URL: | https://chore-catalog-dep-consolidat.packrat-guides-6gq.pages.dev |
Deploying packrat-landing with
|
| Latest commit: |
b039ff3
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7b4d26a0.packrat-landing.pages.dev |
| Branch Preview URL: | https://chore-catalog-dep-consolidat.packrat-landing.pages.dev |
e311793 to
a1d30d1
Compare
There was a problem hiding this comment.
Pull request overview
Consolidates shared dependency versions across workspaces by introducing a root Bun catalog and switching workspace package.json files to catalog: references, with an updated bun.lock.
Changes:
- Added a root-level
catalogfor commonly shared dependencies (including Radix UI packages). - Replaced pinned dependency versions with
catalog:references in multiple workspacepackage.jsonfiles. - Updated
bun.lockto reflect catalog references and resolved versions.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
package.json |
Adds the root catalog that centralizes versions for shared deps. |
apps/landing/package.json |
Switches shared deps (Radix UI, React, Zod, Tailwind, TS) to catalog:. |
apps/guides/package.json |
Switches shared deps (Radix UI, AI/Axios/Chalk, React, Zod, Tailwind, TS) to catalog:. |
packages/api/package.json |
Switches ai, radash, and zod to catalog:. |
packages/analytics/package.json |
Switches chalk, radash, and zod to catalog:. |
packages/guards/package.json |
Switches radash to catalog:. |
bun.lock |
Updates lockfile entries to reflect catalog: usage and new resolved versions. |
| }, | ||
| "catalog": { | ||
| "ai": "^5.0.136", | ||
| "axios": "^1.12.0", | ||
| "chalk": "^5.6.2", | ||
| "radash": "^12.1.1", | ||
| "react": "19.1.0", |
There was a problem hiding this comment.
PR description says axios version mismatches were resolved across the monorepo and that workspace package.json files were converted to catalog: refs, but apps/expo/package.json still pins axios to ^1.8.4 (and doesn’t use catalog:), leaving an axios mismatch vs the root catalog (^1.12.0). Either update Expo to use the catalog entry (and confirm compatibility) or adjust the PR summary/catalog to reflect the intended divergence.
- Fix 6 version mismatches: ai, axios, chalk, radash, react, react-dom - Move zod, typescript, tailwindcss, react, react-dom, ai, axios, chalk, radash, and all @radix-ui/* into root catalog - All workspace packages now use catalog: references for shared deps
a1d30d1 to
b039ff3
Compare
- Rebase onto development (resolve analytics/package.json conflict: keep @packrat/env dep + use catalog: for chalk) - Fix @ts-ignore → @ts-expect-error in useCreatePackFromPack.ts - Add comment-stripping to no-circular-deps.ts (prevents JSDoc false positives) - Break circular imports: catalog/types, profile/types, itemCalculations now point to specific type files instead of barrel indexes - Create packs/input.ts and api/types/validation.ts to break dep cycles - Fix schema.ts to import ValidationError from types/validation - Convert apps/expo and packages/env deps to catalog: (bun catalog entries added by #2070 — ai, axios, radash, react, react-dom, tailwindcss, ts, zod) - Sort package.json files
Convert ai, axios, radash, react, react-dom, tailwindcss, typescript, and zod in apps/expo/package.json to catalog: references. Apply biome formatter fix to PackCard.tsx. Sort root package.json via sort-package-json. All 4 CI checks pass: biome, no-circular-deps, no-duplicate-deps, sort-package-json.
- Rebase onto origin/development to pick up post-#2070 changes - Convert explicit dep versions to catalog: in apps/expo/package.json - Copy fixed files: no-circular-deps.ts, input.ts, catalog/types, profile/types, itemCalculations, api/types/validation, api/types/etl, api/db/schema, useCreatePackFromPack, PackCard - Fix biome errors in new analytics files: remove unused drizzle-orm imports (lt, gt, sum, max), sort imports, apply formatter, suppress noNonNullAssertion with comment
chore(deps): fix version mismatches and consolidate into bun catalog
Convert ai, axios, radash, react, react-dom, tailwindcss, typescript, and zod in apps/expo/package.json to catalog: references. Apply biome formatter fix to PackCard.tsx. Sort root package.json via sort-package-json. All 4 CI checks pass: biome, no-circular-deps, no-duplicate-deps, sort-package-json.
- Rebase onto development (resolve analytics/package.json conflict: keep @packrat/env dep + use catalog: for chalk) - Fix @ts-ignore → @ts-expect-error in useCreatePackFromPack.ts - Add comment-stripping to no-circular-deps.ts (prevents JSDoc false positives) - Break circular imports: catalog/types, profile/types, itemCalculations now point to specific type files instead of barrel indexes - Create packs/input.ts and api/types/validation.ts to break dep cycles - Fix schema.ts to import ValidationError from types/validation - Convert apps/expo and packages/env deps to catalog: (bun catalog entries added by #2070 — ai, axios, radash, react, react-dom, tailwindcss, ts, zod) - Sort package.json files
Summary
ai,axios,chalk,radash,react,react-dom) by resolving each to the highest version used across the monorepocatalogsection to rootpackage.jsonwith 36 entries: the 6 fixed deps pluszod,typescript,tailwindcss, and all 27@radix-ui/*packages shared betweenapps/landingandapps/guidespackage.jsonfiles withcatalog:references (82 total substitutions across 6 packages)Packages updated
apps/expo/package.jsonapps/guides/package.jsonapps/landing/package.jsonpackages/analytics/package.jsonpackages/api/package.jsonpackages/guards/package.jsonTest plan
bun installcompletes successfully and lockfile is updated