fix(dev): consolidated CI hotfix — check-types + biome + unit tests by andrew-bierman · Pull Request #2059 · PackRat-AI/PackRat

andrew-bierman · 2026-04-11T13:24:23Z

Summary

Combines #2055 (unit tests coverage), #2056 (biome errors), and #2057 (check-types errors) into a single PR to break their circular dependency — each individual PR only fixes one category and inherits the other two failures, so none of the three can show green CI on their own.

Errors fixed

Category	Count	Root cause
check-types	28 → 0	Drizzle schema `postComments.parentCommentId` self-reference broke TS recursion limit, collapsing every drizzle relation to `{[x: string]: any}`
biome	26 → 0	Duplicate top-level `overrides` key in `biome.json` silently dropped the `useMaxParams` exemptions from #2049
Expo Unit Tests	coverage 74.32% → 79.87%	#1882 Social feed added `features/feed/utils/` with zero tests, dragging coverage below the 75% threshold

Post-merge fixes

Two additional fixes on top of the 3 branch merges:

`packages/analytics/src/core/catalog-cache.ts` — biome `--unsafe` in the biome-fix branch had deleted the `private catalogInstance` field declaration and its `DuckDBInstance` import, but the assignments still referenced the field. Restored both.
`apps/expo/features/feed/components/PostCard.tsx` — Icon name `"delete"` (from original dev code) was invalid in the nwui allowlist. Replaced with `"trash-can-outline"` matching every other delete button in the app.

Test plan

`bun run check-types` → 0 errors
`bun biome check` → 0 errors
Unit tests coverage > 75%
CI green on all jobs

The Expo Unit Tests CI job on development was failing because the v8 statement-coverage threshold (75%) dropped to 74.32% after recent feature merges. PR #1882 (social feed) and the pack-template weight helpers landed with no unit tests, and vitest.config.ts includes every .ts under `features/**/utils/**` in the coverage report. This adds pure-logic unit tests for two easy-to-cover modules: - features/feed/utils/index.ts: buildPostImageUrl, formatAuthorName, and formatRelativeDate. clientEnvs and getRelativeTime are mocked. - features/pack-templates/utils/computePacktemplateWeight.ts: covers empty templates, base gear, consumables, worn items, quantity, and unit conversion. The expo-app/features/packs/utils barrel is mocked to the two pure conversion helpers so the test does not pull in uploadImage.ts (which imports expo-file-system -> expo-sqlite). Coverage goes from 74.32% -> 79.87% statements; 330/330 tests pass. No production code changes.

The Unit Tests workflow path filter only listed `apps/expo/features/packs/utils/**`, so changes under other feature utils directories (e.g. `features/feed/utils/**`, `features/pack-templates/utils/**`) did not trigger the job even though they are included in `apps/expo/vitest.config.ts` coverage report. Broaden the filter to `apps/expo/features/**/utils/**` to match the vitest `include` pattern, and also trigger on changes to the workflow itself so edits here are verified by a run.

…ence Self-referential FK on postComments.parentCommentId caused TypeScript to hit recursion depth and produce `{ [x: string]: any }` for all drizzle relation queries across the codebase, breaking check-types in ~20 files. Adding an explicit AnyPgColumn return type annotation to the references() callback breaks the type recursion, restoring proper relation inference without changing runtime behavior.

- Add 400 response to POST /feed/:postId/comments to match handler - Replace `example: null` with `example: undefined` on optional int (null is not assignable to number | undefined in the openapi overload)

getPresignedUrl takes (ctx, { command, signOptions }) — the wildlife identify route was calling it with 3 positional args.

…nents Replace invalid icon names (like 'delete') that weren't in the nwui Icon type allowlist. These were causing check-types failures on development after #1882, #1885, #1906 merged.

…reen The suppression was placed above the <Image> element instead of the key prop, so it had no effect and biome still reported the error in CI. Mirrors the fix already applied to PostCard.

…hotfixes # Conflicts: # apps/expo/features/feed/components/PostCard.tsx # apps/expo/features/feed/screens/PostDetailScreen.tsx

…-all-hotfixes

Consolidated merge of fix/dev-check-types, fix/dev-biome, and fix/dev-unit-tests into a single PR so all CI jobs pass at once (the 3 individual PRs each only fixed one category and inherited the other two failures, creating a circular dependency). Post-merge fixes needed on top of the 3 branches: - packages/analytics/src/core/catalog-cache.ts: biome --unsafe in the biome-fix branch had deleted the 'private catalogInstance' field declaration and its DuckDBInstance import, but the assignments still referenced the field. Restored both. - apps/expo/features/feed/components/PostCard.tsx: Icon name "delete" (from original dev code) was invalid in the nwui allowlist. Replaced with "trash-can-outline", matching every other delete button in the app.

coderabbitai · 2026-04-11T13:24:29Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 4e986396-4b8f-4b33-91b6-6bf97acc21ad

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch fix/dev-all-hotfixes

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

github-actions · 2026-04-11T13:25:00Z

Coverage Report for API Unit Tests Coverage (./packages/api)

Status	Category	Percentage	Covered / Total
🔵	Lines	89.66%	902 / 1006
🔵	Statements	89.66% (🎯 80%)	902 / 1006
🔵	Functions	97.95%	48 / 49
🔵	Branches	89.74%	280 / 312

File Coverage

No changed files found.

Generated in workflow #91 for commit 5d2ae68 by the Vitest Coverage Report Action

github-actions · 2026-04-11T13:25:03Z

Coverage Report for Expo Unit Tests Coverage (./apps/expo)

Status	Category	Percentage	Covered / Total
🔵	Lines	79.87%	532 / 666
🔵	Statements	79.87% (🎯 75%)	532 / 666
🔵	Functions	94.64%	53 / 56
🔵	Branches	92.72%	204 / 220

File Coverage

No changed files found.

Generated in workflow #91 for commit 5d2ae68 by the Vitest Coverage Report Action

Copilot

Pull request overview

Consolidates three CI hotfix tracks (typecheck, Biome, and Expo unit test coverage) into one PR so development can return to green CI after recent merges introduced failures across those jobs.

Changes:

Fix Drizzle schema self-referential FK typing to prevent TypeScript inference recursion issues.
Align API OpenAPI contracts and route implementations (feed comment responses, wildlife presigned URL call shape).
Add Expo unit tests for previously-uncovered utilities and update workflow path filters; fix invalid icon names and stale guards import.

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
packages/api/src/schemas/feed.ts	Adjusts feed request schema OpenAPI metadata for `parentCommentId`.
packages/api/src/routes/wildlife/index.ts	Updates `getPresignedUrl` usage to the object-opts signature.
packages/api/src/routes/feed/comments.ts	Adds documented 400 response for add-comment OpenAPI route.
packages/api/src/db/schema.ts	Breaks Drizzle self-reference type recursion via `AnyPgColumn` return typing on `references()`.
packages/analytics/src/core/catalog-cache.ts	Restores missing DuckDB instance tracking field/type after prior auto-fix regression.
apps/expo/features/pack-templates/utils/tests/computePacktemplateWeight.test.ts	Adds unit tests to raise coverage for pack-template weight utils (with safe mocking for Node env).
apps/expo/features/feed/utils/tests/feedUtils.test.ts	Adds unit tests covering feed utility helpers (URL building, author formatting, relative date alias).
apps/expo/features/feed/components/PostCard.tsx	Replaces invalid delete icon name with an allowlisted one.
apps/expo/features/feed/components/CommentItem.tsx	Replaces invalid delete icon name with an allowlisted one.
apps/expo/app/(app)/(tabs)/(home)/index.tsx	Switches `assertIsString` import to `@packrat/guards`.
.github/workflows/unit-tests.yml	Broadens workflow path filters to include `features//utils/` and self-trigger on workflow edits.

Copilot · 2026-04-11T13:28:31Z

  .object({
    content: z.string().min(1).max(1000).openapi({ example: 'Looks amazing!' }),
-    parentCommentId: z.number().int().optional().openapi({ example: null }),
+    parentCommentId: z.number().int().optional().openapi({ example: undefined }),


openapi({ example: undefined }) is not a valid OpenAPI/JSON example value (and can be confusing to readers). Prefer either omitting the example field entirely for this optional property, or using a representative integer example (e.g. 123) and describing that the field should be omitted for top-level comments.

Suggested change

parentCommentId: z.number().int().optional().openapi({ example: undefined }),

parentCommentId: z.number().int().optional(),

Copilot · 2026-04-11T13:28:32Z

+    400: {
+      description: 'Failed to create comment',
+      content: { 'application/json': { schema: ErrorResponseSchema } },
+    },


The route now documents a 400 response, but the handler’s only 400 path (if (!newComment)) is unlikely to ever occur—Drizzle will typically throw on insert failures (e.g. FK violation when parentCommentId doesn’t exist), which would bubble as a 500. Consider validating parentCommentId (exists and belongs to the same postId) before inserting and/or catching insert errors to return a deterministic 400/404 that matches the OpenAPI contract.

fix(dev): consolidated CI hotfix — check-types + biome + unit tests

andrew-bierman added 10 commits April 11, 2026 07:00

fix(api): align feed schema and routes with zod-openapi types

07c5030

- Add 400 response to POST /feed/:postId/comments to match handler - Replace `example: null` with `example: undefined` on optional int (null is not assignable to number | undefined in the openapi overload)

fix(api): pass getPresignedUrl options as object in wildlife route

2a191ef

getPresignedUrl takes (ctx, { command, signOptions }) — the wildlife identify route was calling it with 3 positional args.

fix(expo): use valid SF Symbol icon names in home tile and feed compo…

82d2e73

…nents Replace invalid icon names (like 'delete') that weren't in the nwui Icon type allowlist. These were causing check-types failures on development after #1882, #1885, #1906 merged.

fix(expo/feed): move biome-ignore comment to key prop in PostDetailSc…

b19fd68

…reen The suppression was placed above the <Image> element instead of the key prop, so it had no effect and biome still reported the error in CI. Mirrors the fix already applied to PostCard.

Merge remote-tracking branch 'origin/fix/dev-biome' into fix/dev-all-…

c5e395b

…hotfixes # Conflicts: # apps/expo/features/feed/components/PostCard.tsx # apps/expo/features/feed/screens/PostDetailScreen.tsx

Merge remote-tracking branch 'origin/fix/dev-unit-tests' into fix/dev…

d2e0bf5

…-all-hotfixes

Copilot AI review requested due to automatic review settings April 11, 2026 13:24

github-actions Bot added api ci/cd mobile database labels Apr 11, 2026

Copilot started reviewing on behalf of andrew-bierman April 11, 2026 13:25 View session

Copilot AI reviewed Apr 11, 2026

View reviewed changes

andrew-bierman merged commit 4e21daa into development Apr 11, 2026
12 of 14 checks passed

andrew-bierman deleted the fix/dev-all-hotfixes branch April 11, 2026 13:28

andrew-bierman added a commit that referenced this pull request May 14, 2026

Merge pull request #2059 from PackRat-AI/fix/dev-all-hotfixes

29be333

fix(dev): consolidated CI hotfix — check-types + biome + unit tests

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(dev): consolidated CI hotfix — check-types + biome + unit tests#2059

fix(dev): consolidated CI hotfix — check-types + biome + unit tests#2059
andrew-bierman merged 10 commits into
developmentfrom
fix/dev-all-hotfixes

andrew-bierman commented Apr 11, 2026

Uh oh!

coderabbitai Bot commented Apr 11, 2026

Review skipped

Uh oh!

github-actions Bot commented Apr 11, 2026

Uh oh!

github-actions Bot commented Apr 11, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Apr 11, 2026

Uh oh!

Copilot AI Apr 11, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	parentCommentId: z.number().int().optional().openapi({ example: undefined }),
	parentCommentId: z.number().int().optional(),

Conversation

andrew-bierman commented Apr 11, 2026

Summary

Errors fixed

Post-merge fixes

Test plan

Uh oh!

coderabbitai Bot commented Apr 11, 2026

Review skipped

Uh oh!

github-actions Bot commented Apr 11, 2026

Coverage Report for API Unit Tests Coverage (./packages/api)

Uh oh!

github-actions Bot commented Apr 11, 2026

Coverage Report for Expo Unit Tests Coverage (./apps/expo)

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Apr 11, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 11, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants