fix(biome): fix remaining lint errors — useless fragment, parseInt radix, array index keys#2058
Conversation
- Remove useless fragment wrapper in LocationPicker.tsx (noUselessFragments) - Add radix 10 to parseInt calls in spec-parser.ts (useParseIntRadix) - Use URL as image key instead of array index in PostCard and PostDetailScreen (noArrayIndexKey)
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR addresses the remaining Biome lint violations by making small, targeted code edits across the analytics parser and Expo UI components.
Changes:
- Added explicit radix (
10) toNumber.parseIntcalls in the analytics spec parser. - Removed a useless React fragment wrapper in
LocationPicker. - Replaced array-index-based React keys with stable image-key strings in feed image lists.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/analytics/src/core/spec-parser.ts | Adds radix 10 to parseInt calls to satisfy useParseIntRadix. |
| apps/expo/features/weather/components/LocationPicker.tsx | Removes an unnecessary fragment wrapper to satisfy noUselessFragments. |
| apps/expo/features/feed/screens/PostDetailScreen.tsx | Uses image key string as the React key instead of array index to satisfy noArrayIndexKey. |
| apps/expo/features/feed/components/PostCard.tsx | Uses image key string as the React key instead of array index to satisfy noArrayIndexKey. |
fix(biome): fix remaining lint errors — useless fragment, parseInt radix, array index keys
Summary
<>fragment wrapper inLocationPicker.tsx(noUselessFragments)10toparseIntcalls inspec-parser.ts(useParseIntRadix)PostCardandPostDetailScreen(noArrayIndexKey) — previousbiome-ignorecomments were placed before the element start, but the violation fires at thekeyattribute line; switching tokey={img}removes the issue cleanlyFollow-up to
Closes out the remaining biome errors that were still present after #2054 merged.
🤖 Generated with Claude Code
Co-Authored-By: Claude noreply@anthropic.com