Skip to content

fix(biome): fix remaining lint errors — useless fragment, parseInt radix, array index keys#2058

Merged
andrew-bierman merged 1 commit into
developmentfrom
fix/biome-scripts-cleanup
Apr 11, 2026
Merged

fix(biome): fix remaining lint errors — useless fragment, parseInt radix, array index keys#2058
andrew-bierman merged 1 commit into
developmentfrom
fix/biome-scripts-cleanup

Conversation

@andrew-bierman
Copy link
Copy Markdown
Collaborator

Summary

  • Remove useless <> fragment wrapper in LocationPicker.tsx (noUselessFragments)
  • Add radix 10 to parseInt calls in spec-parser.ts (useParseIntRadix)
  • Use URL as image key instead of array index in PostCard and PostDetailScreen (noArrayIndexKey) — previous biome-ignore comments were placed before the element start, but the violation fires at the key attribute line; switching to key={img} removes the issue cleanly

Follow-up to

Closes out the remaining biome errors that were still present after #2054 merged.


🤖 Generated with Claude Code

Co-Authored-By: Claude noreply@anthropic.com

- Remove useless fragment wrapper in LocationPicker.tsx (noUselessFragments)
- Add radix 10 to parseInt calls in spec-parser.ts (useParseIntRadix)
- Use URL as image key instead of array index in PostCard and PostDetailScreen (noArrayIndexKey)
Copilot AI review requested due to automatic review settings April 11, 2026 13:19
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 11, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: ac448edb-4b75-449c-82af-0f182bce52aa

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/biome-scripts-cleanup

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses the remaining Biome lint violations by making small, targeted code edits across the analytics parser and Expo UI components.

Changes:

  • Added explicit radix (10) to Number.parseInt calls in the analytics spec parser.
  • Removed a useless React fragment wrapper in LocationPicker.
  • Replaced array-index-based React keys with stable image-key strings in feed image lists.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
packages/analytics/src/core/spec-parser.ts Adds radix 10 to parseInt calls to satisfy useParseIntRadix.
apps/expo/features/weather/components/LocationPicker.tsx Removes an unnecessary fragment wrapper to satisfy noUselessFragments.
apps/expo/features/feed/screens/PostDetailScreen.tsx Uses image key string as the React key instead of array index to satisfy noArrayIndexKey.
apps/expo/features/feed/components/PostCard.tsx Uses image key string as the React key instead of array index to satisfy noArrayIndexKey.

@andrew-bierman andrew-bierman merged commit e55ffb0 into development Apr 11, 2026
8 of 11 checks passed
@andrew-bierman andrew-bierman deleted the fix/biome-scripts-cleanup branch April 11, 2026 13:25
andrew-bierman added a commit that referenced this pull request May 14, 2026
fix(biome): fix remaining lint errors — useless fragment, parseInt radix, array index keys
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants