fix(trips): use valid Icon name "map" in TrailConditionsBanner#2053
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Hotfix to restore type-safety in the Expo trips UI by replacing an invalid @roninoss/icons SF Symbol name that was breaking bun run check-types.
Changes:
- Replaced
Iconname"terrain"with"map"inTrailConditionsBannerto match the allowlist and satisfy TypeScript checking.
andrew-bierman
force-pushed
the
fix/trail-conditions-icon
branch
from
8b104eb to
4ff30dd
Compare
- Merge duplicate overrides in biome.json (was silently ignored) - Add scripts/lint/** and .github/scripts/** to useMaxParams override - Add noExplicitAny test-file override to merged overrides array - Fix noArrayIndexKey in feed components (PostCard, CreatePost, PostDetail) - Fix useMaxParams in useWildlifeHistory — consolidate 3 params into opts object - Fix import ordering in (home)/index.tsx and feed/[id].tsx - Add biome-ignore comments in localModelManager.ts and auth/store/user.ts - Auto-format feed screens and hooks 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
#1885 shipped with Icon name="terrain" which isn't in the @roninoss/icons SF Symbol allowlist, breaking check-types on development. Replace with "map" — valid and semantically equivalent for a trail-conditions banner.
andrew-bierman
force-pushed
the
fix/trail-conditions-icon
branch
from
4ff30dd to
3a69f40
Compare
Coverage Report for API Unit Tests Coverage (./packages/api)
File CoverageNo changed files found. |
Coverage Report for Expo Unit Tests Coverage (./apps/expo)
File CoverageNo changed files found. |
fix(trips): use valid Icon name "map" in TrailConditionsBanner
Hotfix. #1885 merged with
Icon name="terrain"which isn't in the@roninoss/iconsSF Symbol allowlist, breakingbun run check-typeson development. Replacing withmap— valid and semantically close.Caught while rebasing #1885 which merged before this fix could land in the same PR.