Refactors ASR node to leverage and emit DialogueUtterance #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derkmed
force-pushed
the
dialogue_refactor_existing_2
branch
from
537be90
to
1a9ddc7
Compare
derkmed
changed the title
derkmed
changed the title
Purg
requested changes
May 23, 2024
Purg
previously approved these changes
May 23, 2024
Purg
previously approved these changes
May 23, 2024
Purg
force-pushed
the
dialogue_refactor_existing_2
branch
from
9a047a5
to
b87f81f
Compare
Purg
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow nodes to be reordered or dropped easily as desired. Furthermore, other nodes can easily be added using the more modular DialogueUtterance msg.