Skip to content

Conversation

@shepmaster
Copy link
Contributor

@shepmaster shepmaster commented Oct 18, 2024

Thanks for using my crate!

Note that version 2.0 increases the MSRV to Rust 1.81. I understand if you don't want to upgrade right away, but hopefully this PR will be useful when you do.

I'm opening these PRs for the top users of twox-hash and have no current plans to become a consistent contributor to this specific repository; please feel free to rewrite the commit as appropriate for your project's requirements.

@timsaucer
Copy link

@PSeitz any chance we could push this forward? I'm willing to help out with whatever the CI failure was to move it along.

@PSeitz PSeitz merged commit 612704f into PSeitz:main Jun 10, 2025
@PSeitz
Copy link
Owner

PSeitz commented Jun 10, 2025

Thx for the PR! I waited some time because of the MSRV.

@timsaucer Why do you need this PR?

@shepmaster shepmaster deleted the twox-hash-bump branch June 10, 2025 22:42
@timsaucer
Copy link

@PSeitz Thank you!

One of the things we do in our repo is to check for duplicate dependencies of different versions. Right now we're in the case where we are using two crates: arrow-ipc and parquet. The parquet crate is using twox-hash v2 and arrow-ipc is using lz4_flex which is using twox-hash v1. This is a small crate, so I added it to our allow list for duplicates, but I wanted to bump this PR so I can put in a PR for arrow-ipc.

@timsaucer timsaucer mentioned this pull request Jun 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants