Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Signature props: signatureCreationModes and signatureColorOptions #418

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ghost1face
Copy link

Details

Provide two new props to the PSPDFKitView component. This allows for further customization of the component to select acceptable signature modes and colors:

import PSPDFKitView, { PDFConfiguration } from "react-native-pspdfkit";

<PSPDFKitView
  configuration={{
    signatureCreationModes: [
        PDFConfiguration.SignatureCreationModes.DRAW, 
        PDFConfiguration.SignatureCreationModes.IMAGE,
        PDFConfiguration.SignatureCreationModes.TYPE
    ],
    signatureColorOptions: [
        "black",
        "#876543",
        "rgb(127, 81, 202)"
    ]
  }}
/>

Implemented both iOS and Android backings

Acceptance Criteria

  • When approved, right before merging, rebase with master and increment the package version in package.json, package-lock.json, samples/Catalog/package.json, samples/Catalog/yarn.lock, samples/NativeCatalog/package.json, and samples/NativeCatalog/yarn.lock (see example commit: b32b4ed).
  • Create a new release (and tag) with the new package version (see https://github.com/PSPDFKit/react-native/releases).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant