Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stamps not being correctly detected #384

Merged
merged 2 commits into from
Jan 11, 2021
Merged

Conversation

irgendeinich
Copy link
Contributor

@irgendeinich irgendeinich commented Jan 5, 2021

Details

We missed a case for converting the instant stamp type to our native annotation type enum. This lead to certain functions not working with stamp annotations.

Acceptance Criteria

Copy link
Contributor

@radazzouz radazzouz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Nice catch! I took the liberty to fix it for iOS in 8001ede

@radazzouz radazzouz added the iOS label Jan 8, 2021
@radazzouz radazzouz merged commit 4b4bada into master Jan 11, 2021
@radazzouz
Copy link
Contributor

As agreed with @irgendeinich in Slack, I am merging this PR to publish a new release.

@irgendeinich irgendeinich deleted the reinhard/fix-stamp-type branch January 12, 2021 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants