Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes issue where the last page view would be layed out incorrectly in single page mode and scroll per spread page trasition after device rotation #377

Merged
merged 2 commits into from
Sep 14, 2020

Conversation

radazzouz
Copy link
Contributor

@radazzouz radazzouz commented Sep 14, 2020

Fixes https://github.com/PSPDFKit/PSPDFKit/issues/25653


Details

How to Reproduce:

  • Modify ConfiguredPDFViewComponent like so:
class ConfiguredPDFViewComponent extends Component {
  render() {
    return (
      <View style={{ flex: 1 }}>
        <PSPDFKitView
          document={"PDFs/Annual Report.pdf"}
          configuration={{
            backgroundColor: processColor("lightgrey"),
            showThumbnailBar: "scrubberBar",
            showDocumentLabel: false,
            useParentNavigationBar: false,
            allowToolbarTitleChange: false,
+           pageMode: 'single',
+           pageTransition: 'scrollPerSpread'
          }}
          toolbarTitle={"Custom Title"}
          style={{ flex: 1, color: pspdfkitColor }}
        />
      </View>
    );
  }
}
  • Go to the last page
  • Rotate the device a few times

Expected:

The last page view should always be centered.

Actual:

The last page view will be layed out incorrectly.

Screen Shot 2020-09-14 at 10 55 22 AM

Acceptance Criteria

…single page mode and scroll per spread page trasition after device rotation
Copy link
Contributor

@steviki steviki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@radazzouz radazzouz merged commit 25d5bc6 into master Sep 14, 2020
@radazzouz radazzouz deleted the rad/fix-last-page-view-layout-after-rotation branch September 14, 2020 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants