Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide default fragment tag for PSPDFKitView #372

Merged
merged 2 commits into from
Jul 7, 2020
Merged

Provide default fragment tag for PSPDFKitView #372

merged 2 commits into from
Jul 7, 2020

Conversation

tomassurin
Copy link
Contributor

This PR adds default fragment tag for the PSPDFKitView. This fixes an issue that prevented PSPDFKitView from loading on Android.

Acceptance Criteria

@tomassurin tomassurin requested a review from radazzouz July 6, 2020 15:42
@tomassurin tomassurin self-assigned this Jul 6, 2020
radazzouz
radazzouz approved these changes Jul 6, 2020
View reviewed changes
Copy link
Contributor

@radazzouz radazzouz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 It does not impact iOS.

@tomassurin tomassurin merged commit 8a6b725 into master Jul 7, 2020
@tomassurin tomassurin deleted the tomas/provide-default-fragment-tag branch July 7, 2020 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@irgendeinich irgendeinich irgendeinich approved these changes

@radazzouz radazzouz radazzouz approved these changes

Assignees

@tomassurin tomassurin

Labels
Android bug READY TO REVIEW
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tomassurin @irgendeinich @radazzouz