Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return a promise when calling PSPDFKit.present() #348

Merged
merged 4 commits into from
Feb 12, 2020

Conversation

irgendeinich
Copy link
Contributor

Resolves #243

Details

Calling present() now returns a promise that either resolves to true or provides the exception that occurred when loading the document.

Acceptance Criteria

… `dismiss`, and `setPageIndex`) methods on iOS
@radazzouz
Copy link
Contributor

@steviki @irgendeinich I just pushed the iOS changes in 83cacd7

Copy link
Contributor

@steviki steviki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iOS part looks good to me!

ios/RCTPSPDFKit/RCTPSPDFKitManager.m Outdated Show resolved Hide resolved
@irgendeinich irgendeinich merged commit b1abc7a into master Feb 12, 2020
@irgendeinich irgendeinich deleted the reinhard/present-promise branch February 12, 2020 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Android] Calling present() returns undefined instead of a promise
6 participants