Fix hot reload breaking the PdfView #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simoarpe
approved these changes
Aug 14, 2019
| @@ -239,8 +248,18 @@ public void setMenuItemGroupingRule(@NonNull MenuItemGroupingRule groupingRule) | |||
| private void setupFragment() { | |||
| if (fragmentTag != null && configuration != null && document != null) { | |||
| PdfFragment pdfFragment = (PdfFragment) fragmentManager.findFragmentByTag(fragmentTag); | |||
| if (pdfFragment != null && pdfFragment.getArguments().getInt(ARG_ROOT_ID) != internalId) { | |||
There was a problem hiding this comment.
Better add also a safety check against null for the bundle (i.e. pdfFragment.getArguments() != null)
tomassurin
approved these changes
Aug 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
The issue was that when reloading the code
PdfFragmentattached by thePdfViewwere not removed. Later when creating a newPdfViewwith the samefragmentTagit would pick up the previous fragment causing the broken UI to appear.Acceptance Criteria
package.json,package-lock.json, andsamples/Catalog/package.json(see example commit: 1bf805f).