Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error handling for annotation manipulations functions #261

Merged
merged 2 commits into from
Jul 25, 2019
Merged

Improve error handling for annotation manipulations functions #261

merged 2 commits into from
Jul 25, 2019

Conversation

radazzouz
Copy link
Contributor

@radazzouz radazzouz commented Jul 24, 2019 •
edited
Loading

Resolves #260

Details

recording

Acceptance Criteria

@radazzouz radazzouz added the iOS label Jul 24, 2019
@radazzouz radazzouz self-assigned this Jul 24, 2019
@radazzouz radazzouz changed the title Improve error handline for annotation manipulations functions Improve error handling for annotation manipulations functions Jul 24, 2019
steviki
steviki approved these changes Jul 25, 2019
View reviewed changes
Copy link
Contributor

@steviki steviki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

irgendeinich
irgendeinich approved these changes Jul 25, 2019
View reviewed changes
Copy link
Contributor

@irgendeinich irgendeinich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't affect Android 👍

@radazzouz radazzouz merged commit 3c473ce into master Jul 25, 2019
@radazzouz radazzouz deleted the rad/improve-error-handling branch July 25, 2019 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@irgendeinich irgendeinich irgendeinich approved these changes

@steviki steviki steviki approved these changes

Assignees

@radazzouz radazzouz

Labels
iOS READY TO REVIEW
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[iOS] Return the error in the reject callbacks on iOS
3 participants
@radazzouz @irgendeinich @steviki