Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CocoaPods integration #235

Merged
merged 5 commits into from
Jun 19, 2019
Merged

Fix CocoaPods integration #235

merged 5 commits into from
Jun 19, 2019

Conversation

radazzouz
Copy link
Contributor

@radazzouz radazzouz commented Jun 18, 2019

Fixes #21


Reported in Z#14462


Details

The current CocoaPods integration is broken. This PR fixes, improves and simplifies the CocoaPods integration. It removes the complex Xcode drag and drop implementation in favor of a much more easier integration.

How to Test:

  • Follow the new integration Steps in cocopods.md
  • For step for use yarn add https://github.com/PSPDFKit/react-native.git#rad/fix-cocoapods-integration instead of yarn add github:PSPDFKit/react-native

Acceptance Criteria

  • The CocoaPods integration works in a newly created app.
  • The normal integration works in a newly created app.
  • The Catalog sample project works.
  • When approved, right before merging, rebase with master and increment the package version in package.json, package-lock.json, and samples/Catalog/package.json (see example commit: 1bf805f).
  • Create a new release (and tag) with the new package version (see https://github.com/PSPDFKit/react-native/releases).

@radazzouz radazzouz force-pushed the rad/fix-cocoapods-integration branch from 52c76bb to 3404e55 Compare June 18, 2019 13:07
Copy link
Contributor

@steviki steviki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍
Tested it, and it works fine.

@radazzouz radazzouz force-pushed the rad/fix-cocoapods-integration branch from 0a311a8 to fe38898 Compare June 19, 2019 11:07
@radazzouz radazzouz merged commit fb77b20 into master Jun 19, 2019
@radazzouz radazzouz deleted the rad/fix-cocoapods-integration branch June 19, 2019 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve the CocoaPods integration
2 participants