Add configuration for page mode and displaying the first page as a single page #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidschreiber
approved these changes
May 24, 2019
android/src/main/java/com/pspdfkit/react/ConfigurationAdapter.java
Outdated
Show resolved
Hide resolved
| configurePageMode(configuration.getString(PAGE_MODE)); | ||
| } | ||
| if (configuration.hasKey(FIRST_PAGE_ALWAYS_SINGLE)) { | ||
| configureFirstPageAlwaysSingle(configuration.getBoolean(FIRST_PAGE_ALWAYS_SINGLE)); |
There was a problem hiding this comment.
What is the default of configuration.getBoolean(...). What does it return if the value that was set is not a boolean?
There was a problem hiding this comment.
If it's not a boolean an exception is thrown, this makes sense in my opinion so users know if they passed an invalid value in the JS code.
anastasia-zaitsewa
approved these changes
May 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #225
Details
We were missing
pageModeand relatedfirstPageAlwaysSinglein theConfigurationAdapterthis adds those missing properties.Acceptance Criteria
package.json,package-lock.json, andsamples/Catalog/package.json(see example commit: 1bf805f).