Skip to content

Commit

Permalink
Upgrade to PSPDFKit 7 for Android (#412)
Browse files Browse the repository at this point in the history
* Change PSPDFKIT_VERSION to Android 7

* Update build.gradle

* Update build.gradle

* Update build.gradle

* Update the run command for the iOS Catalog

* Bump version number to 1.32.0

Co-authored-by: Rad Azzouz <[email protected]>
  • Loading branch information
simoarpe and Rad Azzouz authored Jul 23, 2021
1 parent 571bb01 commit e370675
Show file tree
Hide file tree
Showing 10 changed files with 12 additions and 12 deletions.
4 changes: 2 additions & 2 deletions android/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
* Contains gradle configuration constants
*/
ext {
PSPDFKIT_VERSION = '6.6.2'
PSPDFKIT_VERSION = '7.0.0'
}

buildscript {
Expand All @@ -41,7 +41,7 @@ android {
buildToolsVersion "28.0.3"

defaultConfig {
minSdkVersion 19
minSdkVersion 21
targetSdkVersion 26
versionCode 1
versionName "1.0"
Expand Down
2 changes: 1 addition & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "react-native-pspdfkit",
"version": "1.31.6",
"version": "1.32.0",
"description": "A React Native module for the PSPDFKit library.",
"keywords": [
"react native",
Expand Down
2 changes: 1 addition & 1 deletion samples/Catalog/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ The project contains a large set of sample code, which illustrates how to set up
6. Step into the Catalog project's directory: `cd /samples/Catalog`
7. Install dependencies: `yarn install` in `samples/Catalog` directory. (Because of a [bug](https://github.com/yarnpkg/yarn/issues/2165) you may need to clean `yarn`'s cache with `yarn cache clean` before.)
8. Start the Metro bundler by running `react-native start`
9. Run the app with `react-native-cli`: `react-native run-ios`
9. Run the app with `react-native-cli`: `react-native run-ios --simulator="iPad Pro (12.9-inch) (5th generation)"`

### Troubleshooting

Expand Down
4 changes: 2 additions & 2 deletions samples/Catalog/android/app/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ android {
defaultConfig {
applicationId "com.pspdfkit.react.catalog"
multiDexEnabled true
minSdkVersion 19
minSdkVersion 21
targetSdkVersion 26
versionCode 1
versionName "1.0"
Expand Down Expand Up @@ -233,4 +233,4 @@ tasks.whenTaskAdded { task ->
}
}

apply from: file("../../node_modules/@react-native-community/cli-platform-android/native_modules.gradle"); applyNativeModulesAppBuildGradle(project)
apply from: file("../../node_modules/@react-native-community/cli-platform-android/native_modules.gradle"); applyNativeModulesAppBuildGradle(project)
2 changes: 1 addition & 1 deletion samples/Catalog/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "Catalog",
"version": "1.31.6",
"version": "1.32.0",
"private": true,
"scripts": {
"start": "react-native start",
Expand Down
2 changes: 1 addition & 1 deletion samples/Catalog/yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -5415,7 +5415,7 @@ react-native-permissions@^1.1.1:
integrity sha512-t0Ujm177bagjUOSzhpmkSz+LqFW04HnY9TeZFavDCmV521fQvFz82aD+POXqWsAdsJVOK3umJYBNNqCjC3g0hQ==

"react-native-pspdfkit@file:../..":
version "1.31.6"
version "1.32.0"

react-native-qrcode-scanner@^1.2.1:
version "1.2.1"
Expand Down
2 changes: 1 addition & 1 deletion samples/NativeCatalog/android/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
buildscript {
ext {
buildToolsVersion = "28.0.3"
minSdkVersion = 19
minSdkVersion = 21
compileSdkVersion = 28
targetSdkVersion = 28
}
Expand Down
2 changes: 1 addition & 1 deletion samples/NativeCatalog/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "NativeCatalog",
"version": "1.31.6",
"version": "1.32.0",
"private": true,
"scripts": {
"android": "react-native run-android",
Expand Down
2 changes: 1 addition & 1 deletion samples/NativeCatalog/yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -5506,7 +5506,7 @@ react-native-gesture-handler@^1.3.0:
prop-types "^15.7.2"

"react-native-pspdfkit@file:../..":
version "1.31.6"
version "1.32.0"

react-native-safe-area-view@^0.14.1:
version "0.14.8"
Expand Down

0 comments on commit e370675

Please sign in to comment.