Fix test warnings #1061
Open
Fix test warnings #1061
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1061 +/- ##
==========================================
+ Coverage 72.70% 73.02% +0.32%
==========================================
Files 21 21
Lines 5111 5105 -6
==========================================
+ Hits 3716 3728 +12
+ Misses 1395 1377 -18
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
- Add timeout (600s) and error handling to TPI.py client.gather() with fallback to serial computation - Increase SS.py client.gather() timeout from 300s to 600s for consistency - Update SS.py to use logging.warning instead of print for better consistency - Adjust LocalCluster timeouts in test_TPI.py fixture: - Increase memory_limit from 2GB to 3GB - Increase communication timeout from 300s to 900s - Increase heartbeat_interval from 10s to 30s - Increase death_timeout from 60s to 120s These changes address issues with long-running computationally intensive tasks where communication can break down due to overly aggressive timeouts. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
The previous commit incorrectly used client.gather(timeout=) which is not a valid parameter. This commit fixes the implementation to use the correct approach: - Use distributed.wait() with timeout to wait for futures to complete - Check if any futures did not complete (not_done) and raise TimeoutError - Only call client.gather() after confirming all futures are done - Maintain the same error handling and fallback to serial computation This properly implements timeout handling for long-running dask computations in both TPI.py and SS.py. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
rickecon
approved these changes
Oct 6, 2025
|
@jdebacker. I have reviewed the code of this PR and approved it. Is it ready to merge? |
|
@rickecon Changing to WIP -- still resolving some local tests (dask timing out in some TPI full runs) and looking to improve performance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR seeks to address Issue #1047 and reduce the number of pytest warnings.