ci: Build prqlc-clib as artifacts
#4075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-sixty
commented
Jan 13, 2024
prqlc/bindings/clib/Cargo.toml
Outdated
Comment on lines
16
to
17
| crate_type = ["staticlib", "cdylib"] | ||
| # crate_type = ["cdylib"] |
There was a problem hiding this comment.
@eitsupi do you know what we should have here? We had had it just be cdylib, but then nothing is built under musl. Are we OK to have both?
There was a problem hiding this comment.
I don't know but maybe rust-lang/cargo#8607, rust-lang/rust#59302?
Maybe it's better to just build gnu for now?
There was a problem hiding this comment.
OK, I'll leave them both in for the moment, no harm in producing too much, and we can refine later.
We only have targets for musl for prqlc so I won't make new gnu ones unless we know there'll be a problem. But can move to gnu if anyone raises an issue...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3953
Notes are inline about the exact names and structure being very open to change.
It's mostly a copy-paste from
build-prqlc— though it's also different enough that I wouldn't suggest trying to make a generic action atm.We had a discussion on crate naming on Discord, which might make names change: https://discord.com/channels/936728116712316989/1195504018882035752/1195513591302983731