-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Build prqlc-clib
as artifacts
#4075
Conversation
prqlc/bindings/clib/Cargo.toml
Outdated
crate_type = ["staticlib", "cdylib"] | ||
# crate_type = ["cdylib"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eitsupi do you know what we should have here? We had had it just be cdylib
, but then nothing is built under musl
. Are we OK to have both?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know but maybe rust-lang/cargo#8607, rust-lang/rust#59302?
Maybe it's better to just build gnu for now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I'll leave them both in for the moment, no harm in producing too much, and we can refine later.
We only have targets for musl
for prqlc
so I won't make new gnu
ones unless we know there'll be a problem. But can move to gnu
if anyone raises an issue...
Closes #3953
Notes are inline about the exact names and structure being very open to change.
It's mostly a copy-paste from
build-prqlc
— though it's also different enough that I wouldn't suggest trying to make a generic action atm.We had a discussion on crate naming on Discord, which might make names change: https://discord.com/channels/936728116712316989/1195504018882035752/1195513591302983731