Optional Media Controls for Chromecast style remote

[prabhjotsbhatia-ca]

#554

[PRProd]

Thanks for contributing! 👍🏻

I have a few requests for changes ~

Code style (minor)
line 3719 -

    // Draw Optional MediaControl buttons on CC
    function drawMediaControlButtons(e, config) {
      if (config.show_media_controls==true) {
        return html`
          <button class="remote-button" id="rewind-button" @pointerdown=${e.buttonDown}>
            <ha-icon icon="mdi:rewind"></ha-icon>
          </button>
          <button class="remote-button${playingStatusClass}" id="playpause-button" @pointerdown=${e.buttonDown}>
            <ha-icon icon="mdi:play-pause"></ha-icon>
          </button>
          <button class="remote-button" id="fastforward-button" @pointerdown=${e.buttonDown}>
            <ha-icon icon="mdi:fast-forward"></ha-icon>
          </button>
          `;
      }
      return;
    }

return nothing; removed - (error/critical)
Code style (minor)
line 8375 -

  getChromecastMediaControls(remoteStyle) {
    if (['CC1', 'CC2', 'CC3'].includes(remoteStyle)) {
        return html`
          <label for="showMediaControlsCheckbox">
            <input type="checkbox" id="showMediaControlsCheckbox" name="show_media_controls"
              ?checked=${this._config.show_media_controls === true} @change=${this.configChanged}
            >&nbsp; ${this.translateToUsrLang("Show Media Controls")}
          </label>
          <br>
          <br>`;}
  }

Logic correction - using the config value only triggers the checkbox to appear if a chromecast remote is selected as an override. It does not appear if a chromecast remote is being shown when Remote Style: is set to default. Using getDeviceAttribute("defaultRemoteStyle") will return the visible remote style (bad name for that function, I know... sorry)
UI linebreaks (minor)
Line 8502 -

        <br>
        <br>
        ${this.getChromecastMediaControls(getDeviceAttribute("defaultRemoteStyle"))}

        ${this.getCompatibilityModeDropdown(this._config.compatibility_mode, getDeviceAttribute('friendlyName'))}

        ${this.getAppChoiceOptionMenus(getDeviceAttribute("defaultRemoteStyle"))}

[prabhjotsbhatia-ca]

Thank you for your review and all the work you put into maintaining this repo! Yes, I was a little confused by the getDeviceAttribute("defaultRemoteStyle").

I have made the suggested changes.

[PRProd]

Thanks!

[PRProd]

I'll complete the merge right before the next official release. I like to keep my repo updates a little more "transactional" where changes are immediately available in releases. It helps me keep my sanity. 😄

[prabhjotsbhatia-ca]

No worries, totally understandable!
Lemme know if you'd like some help with other issues.

[PRProd]

@prabhjotsbhatia-ca ~

If you have a Fire TV device or a Shield, there are some things you could dig into here: Technical Help Wanted #115

[prabhjotsbhatia-ca]

Ah I do have a firtev stick but unfortunately the remote got misplaced. Anything else I could help with?

[PRProd]

Thanks again @prabhjotsbhatia-ca!

I just merged this PR and bundled it with the newly published Firemote version v4.1.3