Skip to content

Commit

Permalink
build(docker): mount an empty folder for the integration test results
Browse files Browse the repository at this point in the history
GitHub Actions has seen some failures due to permission problems. This is caused by the mounted folder not existing, so Docker has to create it. On Linux, the permissions are based on the container, which causes a failure when the host tries to subsequently write to it. (This doesn't happen on Macs due to the Docker For Mac intermediary virtual machine.)

So, this makes sure the folder exists but is empty before mounting.

Refs #388
  • Loading branch information
thewilkybarkid committed Aug 16, 2021
1 parent a4d2472 commit e21dc0c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ test: build ## Run the tests
integration-test: export TARGET = integration
integration-test: export LOG_FILE = integration/results/docker.log
integration-test: build ## Run the integration tests
rm -rf integration/results
mkdir -p integration/results && rm -r integration/results/*
${DOCKER_COMPOSE} run --rm playwright; ${LOGS}

smoke-test: build ## Run the smoke tests
Expand Down

0 comments on commit e21dc0c

Please sign in to comment.