Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Falcon PADDED variants #549

Merged
merged 5 commits into from
Mar 6, 2024
Merged

Rename Falcon PADDED variants #549

merged 5 commits into from
Mar 6, 2024

Conversation

SWilson4
Copy link
Collaborator

@SWilson4 SWilson4 commented Mar 5, 2024

Concerns were raised downstream about the naming convention for the recently added Falcon PADDED variants. This PR updates the name to be more usable by downstream consumers of PQClean. No functionality is changed.

Manually checked properties

  • Generated Github workflow (run .github/workflows/generate_workflows.py) (new schemes)
  • No stringification macros
  • Output-parameter pointers in functions are on the left
  • Negative return values on failure of API functions (within restrictions of FO transform).
  • variable declarations at the beginning (except in for (size_t i=...)
  • Optional:
    • All integer types are of fixed size, using stdint.h types (including uint8_t instead of unsigned char)
    • Integers used for indexing are of size size_t

@SWilson4 SWilson4 changed the title Sw falcon padded rename Rename Falcon PADDED variants Mar 5, 2024
@SWilson4 SWilson4 force-pushed the sw-falcon-padded-rename branch from 92b8741 to a472dc1 Compare March 5, 2024 14:55
@SWilson4 SWilson4 marked this pull request as ready for review March 5, 2024 16:31
Copy link

@baentsch baentsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW LGTM, even though I don't understand all machinery at play here (is there some cron CI still waiting to be run?). The YMLs' particularly look OK.

@SWilson4
Copy link
Collaborator Author

SWilson4 commented Mar 5, 2024

CI tracking this branch is passing through both liboqs and oqs-provider.

@SWilson4 SWilson4 merged commit 8e221ae into master Mar 6, 2024
444 checks passed
@SWilson4 SWilson4 deleted the sw-falcon-padded-rename branch March 6, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants