Repository navigation
feat(creator): add notebook-backed youtube control review #884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
POWERFULMOVES
merged 12 commits into
PMOVES.AI-Edition-Hardened
from
feat/pmoves-yt-integration-review
Mar 12, 2026
Merged
Changes from 9 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
201bde1
feat(creator): add yt control worktree review and source classes
hunnibear f3e174d
docs(creator): classify monitored sources and record yt audit
hunnibear fea8aa6
feat(creator): add youtube control action audit table
hunnibear 942ebf6
feat(channel-monitor): bridge youtube control approvals
hunnibear 4aff5a2
feat(channel-monitor): notify messaging gateway for yt approvals
hunnibear 4052a4b
feat(messaging): route yt approval buttons to channel monitor
hunnibear 157d151
docs(agents): add creator notebook traversal context
hunnibear b38cdcd
feat(creator): add notebook-backed youtube control review
hunnibear 24cb93d
fix(creator): harden youtube control review flow
hunnibear e4eb794
fix(ci): fetch submodules and harden yt control audit policy
hunnibear 765e901
fix(ci): fetch only pmoves-yt submodule in python tests
hunnibear 9e7c245
docs(plan): refresh creator-control merge lane
hunnibear File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Submodule PMOVES.YT
updated
6 files
| +33 −14 | .github/workflows/core.yml | |
| +35 −0 | pmoves_yt_service/README.md | |
| +77 −0 | pmoves_yt_service/tests/test_summary_routing.py | |
| +142 −0 | pmoves_yt_service/tests/test_youtube_control.py | |
| +155 −0 | pmoves_yt_service/youtube_control.py | |
| +520 −28 | pmoves_yt_service/yt.py |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
214 changes: 214 additions & 0 deletions
214
pmoves/docs/AGENTS/PMOVES_YT_CONTROL_WORKTREE_REVIEW.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,214 @@ | ||
| # PMOVES.YT Control Worktree Review | ||
|
|
||
| Use this runbook when the task is not just "fix PMOVES.YT", but review the creator-control | ||
| path around it in one isolated worktree. | ||
|
|
||
| This is the correct lane when you need to validate: | ||
| - creator strategy and notebook context | ||
| - PMOVES.YT runtime behavior | ||
| - channel-monitor discovery and queue handoff | ||
| - transcribe-and-fetch fallback or repair posture | ||
| - Invidious / companion fallback reachability | ||
| - Jellyfin packaging or playback linkage | ||
| - Discord / BoTZ operator interaction | ||
| - model-routing posture for transcript, summarization, embeddings, rerank, and multimodal work | ||
|
|
||
| ## Worktree setup | ||
|
|
||
| ```bash | ||
| git worktree add ../PMOVES.AI-wt-yt-integration -b review/pmoves-yt-control | ||
| cd ../PMOVES.AI-wt-yt-integration | ||
| ``` | ||
|
|
||
| Recommended branch naming: | ||
| - `review/pmoves-yt-control` | ||
| - `feat/pmoves-yt-integration-review` | ||
| - `fix/pmoves-yt-control-plane` | ||
|
|
||
| ## Traversal order | ||
|
|
||
| 1. Read `pmoves/docs/PMOVES.AI PLANS/CREATOR_NETWORK_CONTROL_PLANE.md` | ||
| 2. Read `pmoves/docs/AGENTS/SUBMODULE_CODEX_HOMES/PMOVES-Creator.md` | ||
| 3. Read `pmoves/docs/AGENTS/SUBMODULE_CODEX_HOMES/PMOVES-Open-Notebook.md` | ||
| 4. Read `pmoves/docs/AGENTS/SUBMODULE_CODEX_HOMES/PMOVES.YT.md` | ||
| 5. Read `pmoves/docs/AGENTS/SUBMODULE_CODEX_HOMES/PMOVES-transcribe-and-fetch.md` | ||
| 6. Read `pmoves/services/channel-monitor/README.md` | ||
| 7. Read `pmoves/docs/AGENTS/JELLYFIN_CREATOR_WORKTREE_REVIEW.md` | ||
| 8. Read `pmoves/docs/PMOVESCHIT/CATACLYSM_STUDIOS_INC.md` | ||
| 9. Then inspect the live service contracts in code and compose | ||
|
|
||
| ## Review lanes | ||
|
|
||
| ### Lane 0 — creator strategy and notebook context | ||
|
|
||
| - Files: | ||
| - `pmoves/docs/AGENTS/SUBMODULE_CODEX_HOMES/PMOVES-Creator.md` | ||
| - `pmoves/docs/AGENTS/SUBMODULE_CODEX_HOMES/PMOVES-Open-Notebook.md` | ||
| - `pmoves/docs/PMOVESCHIT/CATACLYSM_STUDIOS_INC.md` | ||
| - `CATACLYSM_STUDIOS_INC/README.md` | ||
| - Questions: | ||
| - Is the operator task aligned with creator strategy rather than just service mechanics? | ||
| - Should the task produce notebook artifacts, drafts, or evidence before execution? | ||
| - Does the action fit the Cataclysm Studios platform story, brand, and community posture? | ||
|
|
||
| ### Lane A — PMOVES.YT runtime | ||
|
|
||
| - Files: | ||
| - `PMOVES.YT/pmoves_yt_service/yt.py` | ||
| - `PMOVES.YT/pmoves_yt_service/docs_catalog.py` | ||
| - `PMOVES.YT/pmoves_yt_service/docs_sync.py` | ||
| - `PMOVES.YT/pmoves_yt_service/tests/` | ||
| - Questions: | ||
| - Is PMOVES.YT still the canonical runtime rather than a compatibility shadow? | ||
| - Are ingest, transcript, summarize, chapters, emit, search, docs sync, and docs catalog coherent? | ||
| - Are fallback chains explicit and current? | ||
|
|
||
| ### Lane B — discovery and source control | ||
|
|
||
| - Files: | ||
| - `pmoves/services/channel-monitor/README.md` | ||
| - `pmoves/config/channel_monitor.json` | ||
| - `pmoves/services/channel-monitor/` | ||
| - Questions: | ||
| - Does channel-monitor treat PMOVES.YT as the authoritative queue target? | ||
| - Are source classes and review modes explicit? | ||
| - Is Google API / OAuth preferred where it should be? | ||
|
|
||
| ### Lane C — transcript/fetch auxiliary path | ||
|
|
||
| - Files: | ||
| - `PMOVES-transcribe-and-fetch/` | ||
| - `pmoves/docs/AGENTS/SUBMODULE_CODEX_HOMES/PMOVES-transcribe-and-fetch.md` | ||
| - Questions: | ||
| - Is the auxiliary lane still additive rather than divergent? | ||
| - Is transcript provenance preserved for downstream consumers? | ||
| - Are repair/fallback paths documented against PMOVES.YT rather than replacing it? | ||
|
|
||
| ### Lane D — playback and creator packaging | ||
|
|
||
| - Files: | ||
| - `pmoves/tools/yt_jellyfin_smoke.py` | ||
| - `pmoves/docs/AGENTS/JELLYFIN_CREATOR_WORKTREE_REVIEW.md` | ||
| - Jellyfin bridge and publisher surfaces referenced there | ||
| - Questions: | ||
| - Does PMOVES.YT emit enough metadata for Jellyfin linkage and playback? | ||
| - Are publisher and playback paths still aligned with ingest/search contracts? | ||
|
|
||
| ### Lane E — operator interaction and outreach | ||
|
|
||
| - Files: | ||
| - `PMOVES-BoTZ/` | ||
| - `pmoves/services/publisher-discord/` | ||
| - `pmoves/docs/PMOVES.AI PLANS/CREATOR_NETWORK_CONTROL_PLANE.md` | ||
| - Questions: | ||
| - Are Discord and agent-facing actions review-gated when public-facing? | ||
| - Is creator outreach framed as attribution-aware and human-approved by default? | ||
|
|
||
| ### Lane F — model-routing and provenance | ||
|
|
||
| - Files: | ||
| - `pmoves/docs/MODEL_FABRIC_CONTRACT.md` | ||
| - `pmoves/services/model-registry/` | ||
| - PMOVES.YT runtime env/model references | ||
| - Questions: | ||
| - Are models selected by role and registry mapping rather than hardcoded IDs? | ||
| - Do transcript, summary, embedding, rerank, and multimodal outputs preserve model-family provenance? | ||
|
|
||
| ## Minimum checks | ||
|
|
||
| ```bash | ||
| curl -fsS http://localhost:8077/healthz | ||
| curl -fsS http://localhost:8077/yt/docs/catalog | jq . | ||
| curl -fsS http://localhost:8097/api/monitor/status | jq . | ||
| make -C pmoves channel-monitor-smoke | ||
| make -C pmoves yt-jellyfin-smoke | ||
| make -C pmoves transcribe-and-fetch-smoke | ||
| ``` | ||
|
|
||
| If model-routing changed: | ||
|
|
||
| ```bash | ||
| make -C pmoves model-readiness | ||
| GPU_SMOKE_STRICT=true make -C pmoves smoke-gpu | ||
| ``` | ||
|
|
||
| ## Output expectations | ||
|
|
||
| Use a code-review mindset by default: | ||
| - findings first | ||
| - then concrete code/doc changes | ||
| - then validation evidence | ||
| - then merge order | ||
|
|
||
| When the task affects creator actions, also say: | ||
| - where creator intent should live | ||
| - where notebook evidence should live | ||
| - which CATACLYSM_STUDIOS_INC constraints shaped the recommendation | ||
|
|
||
| If no findings are present, say so explicitly and call out residual risks: | ||
| - creator outreach governance | ||
| - transcript/fetch divergence | ||
| - Jellyfin linkage drift | ||
| - model-routing env drift | ||
|
|
||
| ## Current audit snapshot | ||
|
|
||
| As of March 12, 2026, use these findings as the starting bias for this worktree lane: | ||
|
|
||
| - `channel-monitor` now supports `source_class`, but the checked-in monitor config must also | ||
| classify sources explicitly so owned vs watched behavior is not inferred at runtime. | ||
| - `PMOVES.YT` is the canonical runtime, but its summary lane still hardcodes provider/model envs | ||
| (`YT_SUMMARY_PROVIDER`, `YT_GEMMA_MODEL`, `HF_GEMMA_MODEL`) inside | ||
| `PMOVES.YT/pmoves_yt_service/yt.py`. | ||
| - `PMOVES-transcribe-and-fetch` already exposes a registry-shaped `/api/v1/models` UI path, but | ||
| its backend still carries a large static `AVAILABLE_MODELS` catalog in | ||
| `PMOVES-transcribe-and-fetch/backend/app/app_config.py`. | ||
| - This means creator-model posture is only partially modernized: | ||
| - the UI is closer to registry-driven | ||
| - PMOVES.YT and transcribe/fetch runtime defaults still need convergence on shared | ||
| model-role aliases | ||
| - Invidious + companion fallback is present and should remain part of the runtime review path for | ||
| owned and watched YouTube sources. | ||
| - PMOVES.YT is still stronger on ingest/read/download than owned-channel mutation: | ||
| - yt-dlp + companion + Invidious cover extraction and fallback download paths | ||
| - PMOVES.YT now has a first owned-channel YouTube Data API control slice for playlist-add and | ||
| comment/reply actions, but it is intentionally narrow and approval-gated | ||
| - preview/executed actions now append to `pmoves_core.youtube_control_actions` so the creator | ||
| lane has a durable Supabase audit trail instead of event-only visibility | ||
| - `channel-monitor` now provides queue/list/review endpoints for those actions and approves them | ||
| by calling PMOVES.YT control endpoints directly | ||
| - queued control requests can now optionally notify `messaging-gateway` so Discord-ready review | ||
| prompts come from the same request path | ||
| - `messaging-gateway` now intercepts `ytcontrol:*` button clicks and turns them into | ||
| `channel-monitor` review calls, closing the approval loop from Discord click to PMOVES.YT | ||
| execution | ||
| - broader channel-management tasks and first-class Discord interaction wiring are still follow-up | ||
| work | ||
| - `PMOVES-Creator` and `PMOVES-Open-Notebook` are now part of the intended traversal path for | ||
| creator-control work, but their current Codex homes still need richer operational examples as | ||
| the action surface grows. | ||
| - `CATACLYSM_STUDIOS_INC` should now be treated as the governing context for creator-network | ||
| actions so outreach, automation, and monetization stay aligned with the platform story. | ||
| - `channel-monitor` now publishes notebook-ready creator-control artifacts when Open Notebook | ||
| credentials plus `CHANNEL_MONITOR_YT_NOTEBOOK_ID` are configured, and it persists the resulting | ||
| notebook metadata alongside the pending audit row. | ||
| - `comment_create` review requests can now render a draft template into final comment text before | ||
| approval, and the same rendered summary is surfaced in Discord review messages. | ||
| - the PMOVES.YT control plane now covers `playlist_add`, `playlist_remove`, `playlist_reorder`, | ||
| and `comment_create`; `channel-monitor` strips draft/notebook metadata before execution so the | ||
| live YouTube API payload stays narrow. | ||
|
|
||
| ## Recommended next implementation steps | ||
|
|
||
| 1. Keep creator strategy and notebook artifacts explicit in the AGENTS traversal so action | ||
| requests start with intent, draft context, and approval posture instead of raw endpoint input. | ||
| 2. Keep `channel-monitor` source metadata explicit in config, API payloads, and downstream PMOVES.YT | ||
| ingest metadata. | ||
| 3. Replace PMOVES.YT alias-env bridging with live registry-backed alias resolution where the | ||
| model-registry service is available. | ||
| 4. Move PMOVES-transcribe-and-fetch runtime call paths fully onto shared alias/role resolution, | ||
| since the fallback catalog and registry compatibility seams are now PMOVES-native but the | ||
| backend still mixes direct model ids and alias-based calls in older modules. | ||
| 5. Expand the PMOVES.YT owned-channel control plane further into broader channel-management | ||
| actions and richer comment/reply policy templates now that playlist mutation, notebook | ||
| artifacts, and Discord approval summaries are in place. | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't claim reply support unless it's actually wired.
This snapshot says the first owned-channel slice includes playlist-add plus "comment/reply actions", but the supported action list later in the runbook narrows that to
playlist_add,playlist_remove,playlist_reorder, andcomment_create. If replies are not live yet, this sentence overstates the current control surface.As per coding guidelines, "pmoves/docs/**: Check docs for operational accuracy: Keep status claims aligned with evidence in runbooks and smokes."
🤖 Prompt for AI Agents